Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
	dje@google.com,	pierre.muller@ics-cnrs.unistra.fr,
	gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed May 23 01:55:03 UTC 2012
Date: Fri, 22 Jun 2012 17:19:00 -0000	[thread overview]
Message-ID: <20120622171922.GK2799@adacore.com> (raw)
In-Reply-To: <87ipejib8o.fsf@fleche.redhat.com>

> Mark> So I'd have no objection to requiring C99, except for one
> Mark> style-related issue.  I really, really hate mixing declarations with
> Mark> code (something that C99 started to allow).  So if we switch to
> Mark> requiring C99, I think we should add a rule to the coding standards
> Mark> that variables may only be declared at the start of a block.
> 
> If there is no warning for it, then uses will slip in.

Here is a patch that adds -Wdeclaration-after-statement to the list
of compiler warnings...

Tested on x86_64-linux by rebuilding the native compiler with
--enable-targets=all.

gdb/ChangeLog:

        * configure.ac (build_warnings): Add -Wdeclaration-after-statement.
        * configure: Regenerate.

OK to commit?

Thanks,
-- 
Joel


  reply	other threads:[~2012-06-22 17:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23  1:55 GDB Administrator
2012-05-23  4:18 ` Sergio Durigan Junior
2012-05-23  7:10   ` Andreas Schwab
2012-05-23  7:10   ` Doug Evans
2012-05-23  7:27     ` Doug Evans
2012-05-23  8:19       ` Pierre Muller
2012-05-23 14:45       ` Sergio Durigan Junior
     [not found]       ` <4fbc9d77.0853b40a.641e.ffff90dbSMTPIN_ADDED@mx.google.com>
2012-05-23 14:46         ` Doug Evans
2012-05-23 15:01           ` Doug Evans
2012-05-23 15:27             ` Pedro Alves
2012-05-24 18:55           ` Tom Tromey
2012-05-28 20:44             ` Mark Kettenis
2012-05-28 21:59               ` Joel Brobecker
2012-05-29 13:29               ` Maciej W. Rozycki
2012-06-22 16:05               ` Tom Tromey
2012-06-22 17:19                 ` Joel Brobecker [this message]
2012-06-22 17:31                   ` Joel Brobecker
2012-06-22 17:41                     ` Tom Tromey
2012-06-22 19:02                       ` Joel Brobecker
2012-06-25 19:59                         ` Doug Evans
2012-06-26 13:31                         ` Mark Kettenis
2012-06-26 13:15                   ` Mark Kettenis
2012-06-26 11:51                 ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120622171922.GK2799@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox