From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] decode_line_spec_* cleanup
Date: Thu, 28 Jun 2012 21:10:00 -0000 [thread overview]
Message-ID: <CADPb22Qb-gm5KeJNqMWuAYbBfCMj7QrubG2yw+gZziqt7Hb=Gw@mail.gmail.com> (raw)
In-Reply-To: <87fw9f40e2.fsf@fleche.redhat.com>
On Thu, Jun 28, 2012 at 2:00 PM, Tom Tromey <tromey@redhat.com> wrote:
> Doug> +struct symtabs_and_lines
> Doug> +decode_line_spec_with_current_source_as_default (char *string, int flags)
> Doug> +{
> [...]
> Doug> + /* We use whatever is set as the current source line. We do not try
> Doug> + and get a default or it will recursively call us! */
> Doug> + cursal = get_current_source_symtab_and_line ();
>
> This seems a little weird since this is already the default.
> In a way this makes the "with_current_source_as_default" more confusing,
> since that does not actually name the difference between this function
> and decode_line_1.
I'm moving things around (and renaming them). I didn't want to add
any other changes (the text is unchanged from where it was moved
from).
What's meant here by "get a default", I think, is get a default
current source spec.
next prev parent reply other threads:[~2012-06-28 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 19:55 Doug Evans
2012-06-28 21:01 ` Tom Tromey
2012-06-28 21:10 ` Doug Evans [this message]
2012-06-29 22:49 Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22Qb-gm5KeJNqMWuAYbBfCMj7QrubG2yw+gZziqt7Hb=Gw@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox