From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29056 invoked by alias); 28 Jun 2012 21:10:16 -0000 Received: (qmail 29047 invoked by uid 22791); 28 Jun 2012 21:10:15 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jun 2012 21:10:01 +0000 Received: by vcbfl10 with SMTP id fl10so2222530vcb.0 for ; Thu, 28 Jun 2012 14:10:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=eb+QUVuw1hBrLHcIMq2cMDfgx9Idd+tscdtbxPNe5tQ=; b=RxWzpzSG7sai/BlXPgqGM9I7p4415gSq+WyGPfdUXjtmYPnYD09wK/wXtyIx4GQaXd dOC4M7U9JG0RIuZ59VjfYvlDDLxztAa1vYvFWicBcoR1yZQvj9kQCindKyjANfrQotlb 0XNaZhimISH4hIYDMxstSkQeyJuy3vhS545V2nAizXM1NIVhWqnCTFWobOs7vX87v2iA nGJ5MH4V48hdUvTvmNqTCMC0lrghAn4OgIsqd2r1DxCvzgr4U+SdDdYjJjfh8jH969mO KFyH40YWTeAnOqtPG0gHdZ9c41AY8H4vEj3Ty0RPrrmuvyPh5dEIiv0Umh+jPd30IuKp UUww== Received: by 10.52.30.68 with SMTP id q4mr2081892vdh.131.1340917800086; Thu, 28 Jun 2012 14:10:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.30.68 with SMTP id q4mr2081887vdh.131.1340917799963; Thu, 28 Jun 2012 14:09:59 -0700 (PDT) Received: by 10.52.34.45 with HTTP; Thu, 28 Jun 2012 14:09:59 -0700 (PDT) In-Reply-To: <87fw9f40e2.fsf@fleche.redhat.com> References: <20120628195537.3B6D01E13A1@ruffy2.mtv.corp.google.com> <87fw9f40e2.fsf@fleche.redhat.com> Date: Thu, 28 Jun 2012 21:10:00 -0000 Message-ID: Subject: Re: [RFA] decode_line_spec_* cleanup From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQlZrsSuj+0PlcgubzD1pAFd8W4wOG1LtWgxJGMgY1Hj6w/96aw1+D8OeeSv7d/d0xW8weBSnEqMTcRr/TNDpH4vtU6trqePqgFmpBXGlgV3rBrEtGkbcIw8/zggnw23tB7GbshxLVdad9egH2bnugdMbjVcQnVBtqo3HzfiHepv04x/A/05LWauGDQbI2GBvt/kTo9d X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00866.txt.bz2 On Thu, Jun 28, 2012 at 2:00 PM, Tom Tromey wrote: > Doug> +struct symtabs_and_lines > Doug> +decode_line_spec_with_current_source_as_default (char *string, int= flags) > Doug> +{ > [...] > Doug> + =A0/* We use whatever is set as the current source line. =A0We do= not try > Doug> + =A0 =A0 and get a default =A0or it will recursively call us! =A0*/ > Doug> + =A0cursal =3D get_current_source_symtab_and_line (); > > This seems a little weird since this is already the default. > In a way this makes the "with_current_source_as_default" more confusing, > since that does not actually name the difference between this function > and decode_line_1. I'm moving things around (and renaming them). I didn't want to add any other changes (the text is unchanged from where it was moved from). What's meant here by "get a default", I think, is get a default current source spec.