From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove CHECK_TYPEDEF, use check_typedef instead
Date: Sat, 11 Jul 2015 22:52:00 -0000 [thread overview]
Message-ID: <CADPb22QaGPkKT_MggO-6Y=fobjqwQOZkza2RLP2e2TLMJnPXFA@mail.gmail.com> (raw)
In-Reply-To: <55A1613B.6070707@redhat.com>
On Sat, Jul 11, 2015 at 1:32 PM, Pedro Alves <palves@redhat.com> wrote:
> On 07/11/2015 02:18 PM, Doug Evans wrote:
>
>> I'm not advocating for a really_long_function_name_that_mentions_all_actions,
>> just pointing out that the current situation is lacking.
>> Something like "resolve_type" might work for me,
>> but I haven't put too much time into it.
>
> Agreed with all points.
>
> If we set aside renaming (as it seems like an orthogonal issue, and I'm
> guilty for bringing it up), you in favor or against removing
> CHECK_TYPEDEF, as in Simon's patch?
>
> Myself, I've been acquainted with the CHECK_TYPEDEF macro for so long, that
> it no longer confuses me, but Simon quickly convinced me that as is, two ways
> of doing the exact same isn't much useful and confuses newcomers. So I'm
> leaning on taking his patch.
I'm certainly ok with removing CHECK_TYPEDEF, it's a good step forward IMO.
next prev parent reply other threads:[~2015-07-11 22:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 20:06 Simon Marchi
2015-07-07 13:20 ` Joel Brobecker
2015-07-07 16:15 ` Pedro Alves
2015-07-07 20:15 ` Simon Marchi
2015-07-07 22:01 ` Pedro Alves
2015-07-11 13:19 ` Doug Evans
2015-07-11 18:32 ` Pedro Alves
2015-07-11 22:52 ` Doug Evans [this message]
2015-07-14 9:34 ` Pedro Alves
2015-07-14 20:42 ` Simon Marchi
2015-07-13 17:18 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22QaGPkKT_MggO-6Y=fobjqwQOZkza2RLP2e2TLMJnPXFA@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox