From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124907 invoked by alias); 11 Jul 2015 22:52:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124881 invoked by uid 89); 11 Jul 2015 22:52:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f178.google.com Received: from mail-wi0-f178.google.com (HELO mail-wi0-f178.google.com) (209.85.212.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 11 Jul 2015 22:52:52 +0000 Received: by widjy10 with SMTP id jy10so40415627wid.1 for ; Sat, 11 Jul 2015 15:52:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=FQ4irXPo8mp3gt5DNNi7iUKHANhem6esUckHXs/bjdw=; b=dntjmsmYX78bj4e+pdnNK1BZzF+SJErBGXdXOJf9OjdX5rSbi0WAkyxzFjWGlMMUw5 +fH7PkToC+/xmKJ0MxJRYWfB09OpHVSPgx5d02eTABYkYy2Q2h5L05LlZviffdPXBJJK d0RbwW5a5srfALucEuk8v4gJDfZVryHe9t4I/kaJ/T3d2OF8FttE4FTPd7S+fgFFbt6T PT5HnJpLQJAw3pvhBnNVm7VGuesbdua/iWHvoWKZhdq9+k084BGPrxl3tA4LcYiEoinz bwUIre8cQ6KKs1T61EBOAgimvSSxj/e+Zshyszlw405c9mX3I8dt11j9fSfJTySYAqjr ZyCA== X-Gm-Message-State: ALoCoQnN3baRaMZ+P/JsE9IbA47TL8wpemw3Zg69RzbIjAvHjiIJ/Eg8W0Jgs47/csAeCgcCFUNT X-Received: by 10.180.10.200 with SMTP id k8mr9779535wib.52.1436655169895; Sat, 11 Jul 2015 15:52:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.157.79 with HTTP; Sat, 11 Jul 2015 15:52:09 -0700 (PDT) In-Reply-To: <55A1613B.6070707@redhat.com> References: <1436213157-21480-1-git-send-email-simon.marchi@ericsson.com> <559BFB12.6050606@redhat.com> <55A1613B.6070707@redhat.com> From: Doug Evans Date: Sat, 11 Jul 2015 22:52:00 -0000 Message-ID: Subject: Re: [PATCH] Remove CHECK_TYPEDEF, use check_typedef instead To: Pedro Alves Cc: Simon Marchi , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00350.txt.bz2 On Sat, Jul 11, 2015 at 1:32 PM, Pedro Alves wrote: > On 07/11/2015 02:18 PM, Doug Evans wrote: > >> I'm not advocating for a really_long_function_name_that_mentions_all_actions, >> just pointing out that the current situation is lacking. >> Something like "resolve_type" might work for me, >> but I haven't put too much time into it. > > Agreed with all points. > > If we set aside renaming (as it seems like an orthogonal issue, and I'm > guilty for bringing it up), you in favor or against removing > CHECK_TYPEDEF, as in Simon's patch? > > Myself, I've been acquainted with the CHECK_TYPEDEF macro for so long, that > it no longer confuses me, but Simon quickly convinced me that as is, two ways > of doing the exact same isn't much useful and confuses newcomers. So I'm > leaning on taking his patch. I'm certainly ok with removing CHECK_TYPEDEF, it's a good step forward IMO.