Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] Make cu/tu functions in dwarf.exp take a list of options
Date: Fri, 17 May 2013 18:20:00 -0000	[thread overview]
Message-ID: <CADPb22QEF-QQGkx_msjF8-3E0OMbfGcB4gBG63POHZzWSAgs0w@mail.gmail.com> (raw)
In-Reply-To: <871u95qy90.fsf@fleche.redhat.com>

On Fri, May 17, 2013 at 11:04 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> Ok to check in?
> Doug> Regression tested on amd64-linux.
>
> Looks good to me.
>
> Doug> 2013-05-17  Doug Evans  <dje@google.com>
>
> Doug>   * lib/dwarf.exp (Dwarf): New variable _abbrev_section.
> Doug>   (_handle_DW_TAG): Use it.
> Doug>   (cu): Replace parameters is_64, version, addr_size with options.
> Doug>   All callers updated.  Add Fission support.
>
> I thought we were supposed to list all the changed files, even in this
> case.  If not, it would be nice to know, so I can stop doing that in the
> future.

I've always gone by this in standards.texi.
I don't see any amendment to this in the two wiki pages on coding standards.
[OTOH I haven't been using uppercase for parameter names, but that's typical
in gdb changelogs.]

@node Simple Changes
@subsection Simple Changes

Certain simple kinds of changes don't need much detail in the change
log.

When you change the calling sequence of a function in a simple fashion,
and you change all the callers of the function to use the new calling
sequence, there is no need to make individual entries for all the
callers that you changed.  Just write in the entry for the function
being called, ``All callers changed''---like this:

@example
* keyboard.c (Fcommand_execute): New arg SPECIAL.
All callers changed.
@end example


  reply	other threads:[~2013-05-17 18:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 17:28 Doug Evans
2013-05-17 18:04 ` Tom Tromey
2013-05-17 18:20   ` Doug Evans [this message]
2013-05-20  5:40     ` Joel Brobecker
2013-05-20 16:42       ` Doug Evans
2013-05-20 22:09   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADPb22QEF-QQGkx_msjF8-3E0OMbfGcB4gBG63POHZzWSAgs0w@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox