From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10277 invoked by alias); 17 May 2013 18:20:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10237 invoked by uid 89); 17 May 2013 18:20:46 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-vb0-f42.google.com (HELO mail-vb0-f42.google.com) (209.85.212.42) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 17 May 2013 18:20:45 +0000 Received: by mail-vb0-f42.google.com with SMTP id w16so2526412vbf.1 for ; Fri, 17 May 2013 11:20:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=6PkUyH/eI1WeHKpJwe7oSCiFAmYsgnBifrxzbPdxh7o=; b=UspCYzKJD7r2kl5LWWR0upuy8S8g4SEG2V8FN6lluolQg++IQBimesk/iJgkzfzOiE 0vxdL3Lqo5ZRKiLP0E76daYlXaV3dY12MWozzeO/GHLniva52/rPWkc4DBU1NBHb2vlA blyp6DYc3X4blEjTfs2wt3VSeOxcLReGWX2p/VeHWfr6ZMlQdPZtWZTWqelik24cW33I ifBnrSoNhES+nkFI3bhkB5G0TDcHvGsr7sk+DK7e/kcvXoHlRgpsaolYfMD1W2sYUQlV TlxTEC2lqN2oZG637RXCBocFyMJ2QDxa4LwVsAABUQLE2qSpsAUYkKxDOMS1wW+VwnV+ vUDQ== MIME-Version: 1.0 X-Received: by 10.52.68.49 with SMTP id s17mr25807486vdt.92.1368814843435; Fri, 17 May 2013 11:20:43 -0700 (PDT) Received: by 10.220.54.75 with HTTP; Fri, 17 May 2013 11:20:43 -0700 (PDT) In-Reply-To: <871u95qy90.fsf@fleche.redhat.com> References: <871u95qy90.fsf@fleche.redhat.com> Date: Fri, 17 May 2013 18:20:00 -0000 Message-ID: Subject: Re: [RFA] Make cu/tu functions in dwarf.exp take a list of options From: Doug Evans To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlkk0OeDCZL+CNYi48T/SUb6fMbt9JIbo1UFoLqFni3c+LBTWHwhK/LM2z8zR1jC6cOe+McUjlVpiM5MjKBL5cb5X7dDnkn4M/N+ZSP31mM4mzg63SPHpMKp0BhXcFX98aY7f6neIpLKA/3y8NA7dlfBT4Tanv048KK1arRLpGhpQHkLGFjTonFxkOIKepyA7mxfbLhLhiYWD9LahngyCNTcqINXQ== X-SW-Source: 2013-05/txt/msg00699.txt.bz2 On Fri, May 17, 2013 at 11:04 AM, Tom Tromey wrote: >>>>>> "Doug" == Doug Evans writes: > > Doug> Ok to check in? > Doug> Regression tested on amd64-linux. > > Looks good to me. > > Doug> 2013-05-17 Doug Evans > > Doug> * lib/dwarf.exp (Dwarf): New variable _abbrev_section. > Doug> (_handle_DW_TAG): Use it. > Doug> (cu): Replace parameters is_64, version, addr_size with options. > Doug> All callers updated. Add Fission support. > > I thought we were supposed to list all the changed files, even in this > case. If not, it would be nice to know, so I can stop doing that in the > future. I've always gone by this in standards.texi. I don't see any amendment to this in the two wiki pages on coding standards. [OTOH I haven't been using uppercase for parameter names, but that's typical in gdb changelogs.] @node Simple Changes @subsection Simple Changes Certain simple kinds of changes don't need much detail in the change log. When you change the calling sequence of a function in a simple fashion, and you change all the callers of the function to use the new calling sequence, there is no need to make individual entries for all the callers that you changed. Just write in the entry for the function being called, ``All callers changed''---like this: @example * keyboard.c (Fcommand_execute): New arg SPECIAL. All callers changed. @end example