* [PATCH] Remove "hardware" from comments of "target_insert_breakpoint"
@ 2014-03-09 6:31 Hui Zhu
2014-03-10 6:05 ` Doug Evans
0 siblings, 1 reply; 3+ messages in thread
From: Hui Zhu @ 2014-03-09 6:31 UTC (permalink / raw)
To: gdb-patches ml
This function is for simple breakpoint. So I post a patch to remove "hardware".
Thanks,
Hui
2014-03-09 Hui Zhu <hui@codesourcery.com>
* target.h (target_insert_breakpoint): Remove "hardware" from its
comments.
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -1319,7 +1319,7 @@ int target_write_memory_blocks (VEC(memo
#define target_files_info() \
(*current_target.to_files_info) (¤t_target)
-/* Insert a hardware breakpoint at address BP_TGT->placed_address in
+/* Insert a breakpoint at address BP_TGT->placed_address in
the target machine. Returns 0 for success, and returns non-zero or
throws an error (with a detailed failure reason error code and
message) otherwise. */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Remove "hardware" from comments of "target_insert_breakpoint"
2014-03-09 6:31 [PATCH] Remove "hardware" from comments of "target_insert_breakpoint" Hui Zhu
@ 2014-03-10 6:05 ` Doug Evans
2014-03-10 7:46 ` Hui Zhu
0 siblings, 1 reply; 3+ messages in thread
From: Doug Evans @ 2014-03-10 6:05 UTC (permalink / raw)
To: Hui Zhu; +Cc: gdb-patches ml
On Sat, Mar 8, 2014 at 10:31 PM, Hui Zhu <hui_zhu@mentor.com> wrote:
> This function is for simple breakpoint. So I post a patch to remove
> "hardware".
>
> Thanks,
> Hui
>
> 2014-03-09 Hui Zhu <hui@codesourcery.com>
>
> * target.h (target_insert_breakpoint): Remove "hardware" from its
> comments.
Hi.
Fine by me. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove "hardware" from comments of "target_insert_breakpoint"
2014-03-10 6:05 ` Doug Evans
@ 2014-03-10 7:46 ` Hui Zhu
0 siblings, 0 replies; 3+ messages in thread
From: Hui Zhu @ 2014-03-10 7:46 UTC (permalink / raw)
To: Doug Evans; +Cc: Hui Zhu, gdb-patches ml
On Mon, Mar 10, 2014 at 2:04 PM, Doug Evans <dje@google.com> wrote:
> On Sat, Mar 8, 2014 at 10:31 PM, Hui Zhu <hui_zhu@mentor.com> wrote:
>> This function is for simple breakpoint. So I post a patch to remove
>> "hardware".
>>
>> Thanks,
>> Hui
>>
>> 2014-03-09 Hui Zhu <hui@codesourcery.com>
>>
>> * target.h (target_insert_breakpoint): Remove "hardware" from its
>> comments.
>
> Hi.
> Fine by me. Thanks.
Thanks. Committed as
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=7d03f2eb64305b386f2ae8b733e0a2a143fd4ffd
Best,
Hui
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-10 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-09 6:31 [PATCH] Remove "hardware" from comments of "target_insert_breakpoint" Hui Zhu
2014-03-10 6:05 ` Doug Evans
2014-03-10 7:46 ` Hui Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox