From: Doug Evans <dje@google.com>
To: Aaron Gamble <agamble@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove time waiting for user from walltime in stats
Date: Mon, 21 May 2012 21:01:00 -0000 [thread overview]
Message-ID: <CADPb22Q+xzYbJ72N78eC6i4+6PLaVt6UD2BqNcFK=dR7YASvWQ@mail.gmail.com> (raw)
In-Reply-To: <CAHX8C+J+R3mhDk7Gk_S_e6DOEdbWTXbhvP61cQdRLQokda2wYg@mail.gmail.com>
On Mon, May 21, 2012 at 1:43 PM, Aaron Gamble <agamble@google.com> wrote:
> Oops. Corrected ChangeLog entry:
>
> * utils.c (prompt_for_continue_wait_time): New static global.
> (make_command_stats_cleanup): Initialize it.
> (report_command_stats): Subtract time waiting for user.
> (prompt_for_continue): Track time waiting for user.
>
>
> -Aaron
>
> On Mon, May 21, 2012 at 1:21 PM, Aaron Gamble <agamble@google.com> wrote:
>> Hi,
>>
>> Here is a patch to remove the time a gdb is waiting for a user to
>> respond to paging from gdb's internal statistics. Currently if a user
>> is reading paged output and waits 10 seconds to read/respond, those 10
>> seconds are added to the walltime for the command issued.
>>
>> Time spent waiting for the user is stored in a global static variable
>> in utils.c and is subtracted from the wall time when the stats are
>> printed.
>>
>> 2012-05-21 Aaron Gamble <agamble@google.com>
>>
>> * gdb/utils.c: Added global static variable to track time spend
>> waiting for user in paging
The patch is ok with me.
Give it a few days to see if anyone wants to comment.
next prev parent reply other threads:[~2012-05-21 21:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHX8C++LmtfTqjOvargL3O1WiwL9+RP=3uXqQB0gutSGd+49sA@mail.gmail.com>
2012-05-21 20:22 ` Aaron Gamble
2012-05-21 20:43 ` Aaron Gamble
2012-05-21 21:01 ` Doug Evans [this message]
2012-05-22 20:50 ` Aaron Gamble
2012-05-24 17:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22Q+xzYbJ72N78eC6i4+6PLaVt6UD2BqNcFK=dR7YASvWQ@mail.gmail.com' \
--to=dje@google.com \
--cc=agamble@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox