From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5906 invoked by alias); 21 May 2012 21:01:20 -0000 Received: (qmail 5888 invoked by uid 22791); 21 May 2012 21:01:19 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 May 2012 21:01:06 +0000 Received: by vcbfl10 with SMTP id fl10so588489vcb.0 for ; Mon, 21 May 2012 14:01:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=XP+odJUIf/TwS5GbLS8HE+Hix9ymomizpHY/PGzzAv4=; b=nfZ2MDLziwcU+SjXv2QiG5RGfvAjEmwSwAwApVq8+sI+gy8aVRkNW7Xc5n+hwywrVZ ejpk1miBs7KQOSZh1byKOwFTb9AqUoliCVd2f7ArYJy8yjSjCwSbhdh4qJnTr1nup8hz Jn9omDVCvhf8L038tyYV/5RrFkZLsFkH0jDqOhNUgiphO9L8K2QpmuY5GEkvXVUi43D3 eEAYAnmMzqBu4C7w6CO+ae593LTyZ0cxTFdLMttvHAOGhBSUrFUIIR5XB4Yff84jUYaf rrWFniytUYmQwE63rRxJnc9nbK82NPXQp2YaVBEzbdaRk+CpiWDAdmxzN7YZRjGrgZtt TaKQ== Received: by 10.52.73.132 with SMTP id l4mr10292971vdv.4.1337634065696; Mon, 21 May 2012 14:01:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.73.132 with SMTP id l4mr10292965vdv.4.1337634065549; Mon, 21 May 2012 14:01:05 -0700 (PDT) Received: by 10.52.172.166 with HTTP; Mon, 21 May 2012 14:01:05 -0700 (PDT) In-Reply-To: References: Date: Mon, 21 May 2012 21:01:00 -0000 Message-ID: Subject: Re: [PATCH] Remove time waiting for user from walltime in stats From: Doug Evans To: Aaron Gamble Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQkSAiakMd8WwaOLL+0iCns30sKgjH8d10UvWhxPUJ8YaNxGENSPmfkD0VLjpRoyburoNx68nh+KNpf1NvV1UIs7NpjR89MKaSxETrLwNEMq/linZ0Wfqh1E+iMJD+l8dlotnQ9RpPL1K7iuzvoXxAluYPFiIA== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00792.txt.bz2 On Mon, May 21, 2012 at 1:43 PM, Aaron Gamble wrote: > Oops. Corrected ChangeLog entry: > > =A0 =A0 =A0* utils.c (prompt_for_continue_wait_time): New static global. > =A0 =A0 =A0 (make_command_stats_cleanup): Initialize it. > =A0 =A0 =A0 (report_command_stats): Subtract time waiting for user. > =A0 =A0 =A0 (prompt_for_continue): Track time waiting for user. > > > -Aaron > > On Mon, May 21, 2012 at 1:21 PM, Aaron Gamble wrote: >> Hi, >> >> Here is a patch to remove the time a gdb is waiting for a user to >> respond to paging from gdb's internal statistics. Currently if a user >> is reading paged output and waits 10 seconds to read/respond, those 10 >> seconds are added to the walltime for the command issued. >> >> Time spent waiting for the user is stored in a global static variable >> in utils.c and is subtracted from the wall time when the stats are >> printed. >> >> 2012-05-21 =A0Aaron Gamble =A0 >> >> =A0 =A0 * gdb/utils.c: Added global static variable to track time spend >> waiting for user in paging The patch is ok with me. Give it a few days to see if anyone wants to comment.