From: Denis Chertykov <chertykov@gmail.com>
To: Pitchumani Sivanupandi <pitchumani.s@atmel.com>
Cc: gdb-patches@sourceware.org, lgustavo@codesourcery.com,
troth@openavr.org, palves@redhat.com
Subject: Re: [patch, avr] Fix argument passing for call
Date: Sat, 05 Mar 2016 12:21:00 -0000 [thread overview]
Message-ID: <CADOs=zY0wxc3GSrya6N7KNK3WoohPyjWhhp79DanuzokXUvp1A@mail.gmail.com> (raw)
In-Reply-To: <20160301110937.GA3892@CHELT0346>
2016-03-01 14:09 GMT+03:00 Pitchumani Sivanupandi <pitchumani.s@atmel.com>:
> When calling function with argument of size more than 8 bytes fails with
> an error "That operation is not available on integers of more than 8 bytes.".
> avr-gdb considers only 8 bytes (sizeof(long long)) in case of passing the
> argument in registers. When the argument is of size more than 8 byte
> then the utility function to extract bytes failed with the above error.
>
> Attached a patch fix this issue. This patch includes the fix discussed
> here: https://sourceware.org/ml/gdb-patches/2016-02/msg00884.html
> (Both fixes are in same function and the earlier is not committed)
>
> Ran the tests for avr-gdb with internal simulators. No new regressions.
>
> If ok, could someone commit please? I do not have commit access.
>
> Regards,
> Pitchumani
>
> gdb/ChangeLog
>
> 2016-03-01 Pitchumani Sivanupandi<pitchumani.s@atmel.com>
>
> * avr-tdep.c (AVR_LAST_ARG_REGNUM): Define.
> (avr_push_dummy_call): Correct last needed argument register.
> Write MSB of argument into register and subsequent bytes into
> other registers in decreasing order.
Committed.
Denis.
prev parent reply other threads:[~2016-03-05 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 11:09 Pitchumani Sivanupandi
2016-03-05 12:21 ` Denis Chertykov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADOs=zY0wxc3GSrya6N7KNK3WoohPyjWhhp79DanuzokXUvp1A@mail.gmail.com' \
--to=chertykov@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=palves@redhat.com \
--cc=pitchumani.s@atmel.com \
--cc=troth@openavr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox