From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90081 invoked by alias); 5 Mar 2016 12:21:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90042 invoked by uid 89); 5 Mar 2016 12:21:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=denis X-HELO: mail-wm0-f46.google.com Received: from mail-wm0-f46.google.com (HELO mail-wm0-f46.google.com) (74.125.82.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 05 Mar 2016 12:21:05 +0000 Received: by mail-wm0-f46.google.com with SMTP id n186so24970593wmn.1 for ; Sat, 05 Mar 2016 04:21:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nVf1iA1u1541N8c+CwMm4nzn3ShI0EHn4jjO5Rkqnd8=; b=D+n8lx0mbSNViO5nZfw1csXA12BMgVW3wvuRZ6nRCbwh/Vgbjoww+Ahm4d4weZwi6c uadxluDlGfz++jlXOnYGw55FrFQOj+ELd9542kLhA/xrXPbWno1067QT5uBXvof0KGpn piRGG57hE71/HdaBUfHo6PVps9kr297w8yjvpuB7OE3dD3eBvxJaAJJX7WcyY2paZzIz 6utfeD+SqKBD/lLr4KXeYFhtEsHBnHJke9vr0V4vdl8ff5v3lza/FBE3u7Po+Wb+g/mC kR6OHiDOCQoNRBmeSdcaP4K60hqBN7r/0juQakLaM1T5GCAsuFia5f/x4pQqK0fslfX/ zaZg== X-Gm-Message-State: AD7BkJI8Jf65hPPeUOfVIQCS3IK0YgiMgreZ5jb59jo7Bl5NIRZqQWofSNtL2chHjO5jsE2SOp6JoqysaOPwrw== X-Received: by 10.194.77.193 with SMTP id u1mr13654847wjw.73.1457180462355; Sat, 05 Mar 2016 04:21:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.179.193 with HTTP; Sat, 5 Mar 2016 04:20:42 -0800 (PST) In-Reply-To: <20160301110937.GA3892@CHELT0346> References: <20160301110937.GA3892@CHELT0346> From: Denis Chertykov Date: Sat, 05 Mar 2016 12:21:00 -0000 Message-ID: Subject: Re: [patch, avr] Fix argument passing for call To: Pitchumani Sivanupandi Cc: gdb-patches@sourceware.org, lgustavo@codesourcery.com, troth@openavr.org, palves@redhat.com Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-03/txt/msg00098.txt.bz2 2016-03-01 14:09 GMT+03:00 Pitchumani Sivanupandi : > When calling function with argument of size more than 8 bytes fails with > an error "That operation is not available on integers of more than 8 bytes.". > avr-gdb considers only 8 bytes (sizeof(long long)) in case of passing the > argument in registers. When the argument is of size more than 8 byte > then the utility function to extract bytes failed with the above error. > > Attached a patch fix this issue. This patch includes the fix discussed > here: https://sourceware.org/ml/gdb-patches/2016-02/msg00884.html > (Both fixes are in same function and the earlier is not committed) > > Ran the tests for avr-gdb with internal simulators. No new regressions. > > If ok, could someone commit please? I do not have commit access. > > Regards, > Pitchumani > > gdb/ChangeLog > > 2016-03-01 Pitchumani Sivanupandi > > * avr-tdep.c (AVR_LAST_ARG_REGNUM): Define. > (avr_push_dummy_call): Correct last needed argument register. > Write MSB of argument into register and subsequent bytes into > other registers in decreasing order. Committed. Denis.