From: "Francois H. Theron" <francois.theron@netronome.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gcc-patches@gnu.org, binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] [configure] Added "nfp" to the build for binutils.
Date: Tue, 01 May 2018 11:41:00 -0000 [thread overview]
Message-ID: <CACv6nkm1DfdX0KjFJ08ojbqxRpfbwO6HWnn1=xp=1unBJdpc_g@mail.gmail.com> (raw)
In-Reply-To: <20180430195210.rx3krpbwcckkjifs@adacore.com>
On 30 April 2018 at 21:52, Joel Brobecker <brobecker@adacore.com> wrote:
>> +2018-04-30 Francois H. Theron <francois.theron@netronome.com>
>> +
>> + * config.sub: Added "nfp" to basic_machine list.
>> + * configure.ac: Added "nfp" target.
>> + * configure: Regenerate.
>
> I am not a maintainer, but I noticed that config.sub is not being
> modified by this commit -- a small discrepancy between the patch
> and the propose ChangeLog entry.
That was a mistake when splitting the diff to have config.sub
separate. For the record, it has been accepted here after the
maintainer graciously added a ChangeLog entry and a test-case:
http://git.savannah.gnu.org/cgit/config.git/commit/?id=d23f148145b62e7dea44581097f60358118f87f8
For this patch, I can resubmit a new patch with the config.sub line
removed from ChangeLog or ask that the maintainer removes this one
line when committing. Or if I misunderstood the contribution process I
can add the now accepted config.sub to the patch and not change the
ChangeLog.
Francois
next prev parent reply other threads:[~2018-05-01 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 18:21 Francois H. Theron
2018-04-30 19:52 ` Joel Brobecker
2018-05-01 11:41 ` Francois H. Theron [this message]
2018-05-01 15:28 ` Nick Clifton
2018-05-01 15:32 ` Francois H. Theron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACv6nkm1DfdX0KjFJ08ojbqxRpfbwO6HWnn1=xp=1unBJdpc_g@mail.gmail.com' \
--to=francois.theron@netronome.com \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gcc-patches@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox