From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80162 invoked by alias); 1 May 2018 11:41:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80142 invoked by uid 89); 1 May 2018 11:41:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f42.google.com Received: from mail-wm0-f42.google.com (HELO mail-wm0-f42.google.com) (74.125.82.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 May 2018 11:41:54 +0000 Received: by mail-wm0-f42.google.com with SMTP id l1so18691603wmb.2 for ; Tue, 01 May 2018 04:41:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jYUWeIQcnubfhChFOVxnm00lmTncmLpsurXFsuEEi+A=; b=evyCXNVRjCw8b7QO48kn+wuWUi19QJxQaRzONw9vAn2KetRyiVEBEY9U2ft5xGWhIL FFxJXlUqAlar0l9MtX5G+f7Iujzm02sdG7QlMBCTdTxxMo5pl0UORawd1+t4XJ4LGOP1 zXmerVkH9/1+9zTKGCbZxdRe6EYQtccktcRq5KItC4C67R8EHX0WXyC7ul3BSp+5rRL0 G928qrip8XJxzqecuXL1FoDLPMjI8CfKEV/dByTISjXE5/oRSFm305ICXCtdwHuaHApy 2BaTrRT4/iUY/cB+m0DPG1mCuJue+5Ru5utjoZw2cmEXx/EF7GieHqaMFDgNuDyjgb7q bBQQ== X-Gm-Message-State: ALQs6tC0j9KEfyqoK4f7/3m6jVVsiw+p+YYzwYcgQTH9AQ69EQzQvBof 1i3F6hZX4XIS365d544lrC9r+zRZ/07LkG69E6XpEw== X-Google-Smtp-Source: AB8JxZpdoN7IUWd+I9TH6kyDaY/y9zHTNuHaks23Ao18YxHU8CRuaTJhER/y5VVYuO4WYrBe9jHQO42qhg0jWRl3q4A= X-Received: by 10.28.74.217 with SMTP id n86mr8426606wmi.0.1525174911906; Tue, 01 May 2018 04:41:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.64.197 with HTTP; Tue, 1 May 2018 04:41:51 -0700 (PDT) In-Reply-To: <20180430195210.rx3krpbwcckkjifs@adacore.com> References: <20180430182141.28935-1-francois.theron@netronome.com> <20180430195210.rx3krpbwcckkjifs@adacore.com> From: "Francois H. Theron" Date: Tue, 01 May 2018 11:41:00 -0000 Message-ID: Subject: Re: [PATCH] [configure] Added "nfp" to the build for binutils. To: Joel Brobecker Cc: gcc-patches@gnu.org, binutils@sourceware.org, gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-05/txt/msg00004.txt.bz2 On 30 April 2018 at 21:52, Joel Brobecker wrote: >> +2018-04-30 Francois H. Theron >> + >> + * config.sub: Added "nfp" to basic_machine list. >> + * configure.ac: Added "nfp" target. >> + * configure: Regenerate. > > I am not a maintainer, but I noticed that config.sub is not being > modified by this commit -- a small discrepancy between the patch > and the propose ChangeLog entry. That was a mistake when splitting the diff to have config.sub separate. For the record, it has been accepted here after the maintainer graciously added a ChangeLog entry and a test-case: http://git.savannah.gnu.org/cgit/config.git/commit/?id=d23f148145b62e7dea44581097f60358118f87f8 For this patch, I can resubmit a new patch with the config.sub line removed from ChangeLog or ask that the maintainer removes this one line when committing. Or if I misunderstood the contribution process I can add the now accepted config.sub to the patch and not change the ChangeLog. Francois