From: Matt Rice <ratmice@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: pmuldoon@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch] [python] find_line_pc_range
Date: Mon, 04 Jul 2011 10:56:00 -0000 [thread overview]
Message-ID: <CACTLOFqppKbUTP7NMauBXJKy+3ptuKzETzU5Ds6Zad1uBvHoVg@mail.gmail.com> (raw)
In-Reply-To: <E1QdgWn-0000jL-3M@fencepost.gnu.org>
On Mon, Jul 4, 2011 at 3:37 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Sun, 3 Jul 2011 23:03:51 -0700
>> From: Matt Rice <ratmice@gmail.com>
>> Cc: gdb-patches@sourceware.org
>>
>> Thanks, attached is an updated patch that also includes tests.
>>
>> 2011-07-03 Matt Rice <ratmice@gmail.com>
>>
>> * python/py-symtab.c: Populate sal_object_methods.
>> (salpy_find_line_pc_range): New function.
>>
>> 2011-07-03 Matt Rice <ratmice@gmail.com>
>>
>> * gdb.texinfo (Symbol Tables In Python): Add find_line_pc_range method.
>>
>> 2011-07-03 Matt Rice <ratmice@gmail.com>
>>
>> * gdb.python/py-symtab.exp: New Tests for find_line_pc_range.
>
> Thanks.
>
> Comments about the documentation part:
>
>> +@defmethod Symtab_and_line find_line_pc_range
>> +If found returns a @code{Tuple} containing the start and end program counter
>> +addresses for the line attribute. Otherwise returns @code{None}.
>
> Sorry, I don't understand what you are trying to say here.
> "If found"
> what?
Sorry, I abhor writing.
find_line_pc_range will not find a range in cases where
the code is not associated with a line (no debug symbols), or the line
is not associated with code (ifdef'd out or something).
> And what "line attribute" do you refer to?
this thing:
— Instance Variable of Symtab_and_line: line
Indicates the current line number for this object. This attribute is
not writable.
next prev parent reply other threads:[~2011-07-04 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 4:03 Matt Rice
2011-07-03 16:35 ` Phil Muldoon
2011-07-04 5:38 ` Phil Muldoon
2011-07-04 6:36 ` Matt Rice
2011-07-04 10:09 ` Phil Muldoon
2011-07-05 2:47 ` Matt Rice
2011-07-05 20:41 ` Phil Muldoon
2011-07-04 10:50 ` Eli Zaretskii
2011-07-04 10:56 ` Matt Rice [this message]
2011-07-04 13:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACTLOFqppKbUTP7NMauBXJKy+3ptuKzETzU5Ds6Zad1uBvHoVg@mail.gmail.com \
--to=ratmice@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox