[patch] [python] find_line_pc_range

[Matt Rice <ratmice@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

don't know a whole much about python but,
would it be better to return None on error, instead of a tuple containing Nones?

using it to have a linespec enabled disas command, similar to:
python
x = gdb.decode_line("test.c:14")[1][0].find_line_pc_range();
gdb.execute("disassemble " + str(x[0]) + "," + str(x[1]))
end

2011-07-01  Matt Rice  <ratmice@gmail.com>

        * python/py-symtab.c: Populate sal_object_methods.
        (salpy_find_line_pc_range): New function.

2011-07-01  Matt Rice  <ratmice@gmail.com>

        * gdb.texinfo (Symbol Tables In Python): Add find_line_pc_range method.

[-- Attachment #2: foo.diff --]
[-- Type: application/octet-stream, Size: 2110 bytes --]

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index dbaf30e..c0fd555 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -23293,6 +23293,13 @@ exist in @value{GDBN} any longer.  All other
 @code{gdb.Symtab_and_line} methods will throw an exception if it is
 invalid at the time the method is called.
 @end defmethod
+
+@defmethod Symtab_and_line find_line_pc_range
+Returns a @code{Tuple} with the start and end program counter addresses
+for the line attribute of the @code{gdb.Symtab_and_line} object.
+The start and end addresses will be @code{None} if it could not find the
+specified line.
+@end defmethod
 @end table
 
 A @code{gdb.Symtab} object has the following attributes:
diff --git a/gdb/python/py-symtab.c b/gdb/python/py-symtab.c
index 107cdec..678dea3 100644
--- a/gdb/python/py-symtab.c
+++ b/gdb/python/py-symtab.c
@@ -215,6 +215,36 @@ salpy_get_line (PyObject *self, void *closure)
 }
 
 static PyObject *
+salpy_find_line_pc_range (PyObject *self, PyObject *args)
+{
+  struct symtab_and_line *sal = NULL;
+  CORE_ADDR start_pc, end_pc;
+  PyObject *start;
+  PyObject *end;
+  PyObject *ret_tuple;
+
+  SALPY_REQUIRE_VALID (self, sal);
+
+  ret_tuple = PyTuple_New (2);
+
+  if (find_line_pc_range (*sal, &start_pc, &end_pc))
+    {
+
+      start = gdb_py_long_from_ulongest (start_pc);
+      end = gdb_py_long_from_ulongest (end_pc);
+      PyTuple_SET_ITEM (ret_tuple, 0, start);
+      PyTuple_SET_ITEM (ret_tuple, 1, end);
+    }
+  else
+    {
+      PyTuple_SET_ITEM (ret_tuple, 0, Py_None);
+      PyTuple_SET_ITEM (ret_tuple, 1, Py_None);
+    }
+
+  return ret_tuple;
+}
+
+static PyObject *
 salpy_get_symtab (PyObject *self, void *closure)
 {
   struct symtab_and_line *sal;
@@ -526,6 +556,8 @@ static PyMethodDef sal_object_methods[] = {
   { "is_valid", salpy_is_valid, METH_NOARGS,
     "is_valid () -> Boolean.\n\
 Return true if this symbol table and line is valid, false if not." },
+  { "find_line_pc_range", salpy_find_line_pc_range, METH_NOARGS,
+    "Return a tuple of start and end ranges for the symbol table." },
   {NULL}  /* Sentinel */
 };