Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Matt Rice <ratmice@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA 7/9] Explicit locations v2 - CLI for explicit locations
Date: Fri, 09 May 2014 00:48:00 -0000	[thread overview]
Message-ID: <CACTLOFpYDEv0T_QQgXgLRpXk9TnwYTyfZvvda1E+uAfZdYE_4A@mail.gmail.com> (raw)
In-Reply-To: <536BC707.4030300@redhat.com>

On Thu, May 8, 2014 at 11:03 AM, Keith Seitz <keiths@redhat.com> wrote:
> Hi,
>
> This patch starts exposing these new features to users. This patch adds the
> ability to specify explicit locations via the CLI:
>
>         (explicit_location_lex_one): New function.

+static char *
+explicit_location_lex_one (const char **inp,
+               const struct language_defn *language)
+{
....
+      /* If quoted, skip to the ending quote.  */
+      if (strchr (get_gdb_linespec_parser_quote_characters (), *start))

Just curious if we need this quote handling in explicit linespec's

I thought (though i'm not terribly familiar with c++ linespecs)
that the quotes were for operator+, clashing with foo+offset
and 'something::foo' clashing with file:line stuff,

where it isn't obvious to me the need for it arises when using
explicit locations.
I suppose break -source '/path with spaces/foo.c' -line +42

my main curiosity here is for languages which allow the ' character,
particularly the ML family's usage of type variables[1]. to
discriminate polymorphic functions of the variety break -function
foo('a) vs break -function foo(string).

Given that this isn't really a language gdb currently supports or that
anyone is attempting to add support for (to my knowledge) consider it
with whatever priority you deem appropriate.

I Suppose the above -source style of quoting would push ML support
further in the direction of the ada specific code underneath what i'd
quoted above... hmm

http://en.wikipedia.org/wiki/Type_variable


  reply	other threads:[~2014-05-09  0:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 18:03 Keith Seitz
2014-05-09  0:48 ` Matt Rice [this message]
2014-05-09 16:37   ` Keith Seitz
2014-05-10  0:25     ` Matt Rice
2014-05-10  2:03       ` Keith Seitz
2014-05-30 18:19 ` Keith Seitz
2014-08-06  4:46   ` Doug Evans
2014-09-03 19:33     ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACTLOFpYDEv0T_QQgXgLRpXk9TnwYTyfZvvda1E+uAfZdYE_4A@mail.gmail.com \
    --to=ratmice@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox