From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22172 invoked by alias); 9 May 2014 00:48:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22159 invoked by uid 89); 9 May 2014 00:48:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f172.google.com Received: from mail-lb0-f172.google.com (HELO mail-lb0-f172.google.com) (209.85.217.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 09 May 2014 00:48:25 +0000 Received: by mail-lb0-f172.google.com with SMTP id l4so4708419lbv.31 for ; Thu, 08 May 2014 17:48:22 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.35.202 with SMTP id k10mr8273647lbj.14.1399596501847; Thu, 08 May 2014 17:48:21 -0700 (PDT) Received: by 10.114.184.105 with HTTP; Thu, 8 May 2014 17:48:21 -0700 (PDT) In-Reply-To: <536BC707.4030300@redhat.com> References: <536BC707.4030300@redhat.com> Date: Fri, 09 May 2014 00:48:00 -0000 Message-ID: Subject: Re: [RFA 7/9] Explicit locations v2 - CLI for explicit locations From: Matt Rice To: Keith Seitz Cc: "gdb-patches@sourceware.org ml" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00105.txt.bz2 On Thu, May 8, 2014 at 11:03 AM, Keith Seitz wrote: > Hi, > > This patch starts exposing these new features to users. This patch adds the > ability to specify explicit locations via the CLI: > > (explicit_location_lex_one): New function. +static char * +explicit_location_lex_one (const char **inp, + const struct language_defn *language) +{ .... + /* If quoted, skip to the ending quote. */ + if (strchr (get_gdb_linespec_parser_quote_characters (), *start)) Just curious if we need this quote handling in explicit linespec's I thought (though i'm not terribly familiar with c++ linespecs) that the quotes were for operator+, clashing with foo+offset and 'something::foo' clashing with file:line stuff, where it isn't obvious to me the need for it arises when using explicit locations. I suppose break -source '/path with spaces/foo.c' -line +42 my main curiosity here is for languages which allow the ' character, particularly the ML family's usage of type variables[1]. to discriminate polymorphic functions of the variety break -function foo('a) vs break -function foo(string). Given that this isn't really a language gdb currently supports or that anyone is attempting to add support for (to my knowledge) consider it with whatever priority you deem appropriate. I Suppose the above -source style of quoting would push ML support further in the direction of the ada specific code underneath what i'd quoted above... hmm http://en.wikipedia.org/wiki/Type_variable