Re: [PATCH] gdb/tui: add 'set tui mouse-events off' to restore mouse selection

[strager via Gdb-patches <gdb-patches@sourceware.org>]

On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX <lsix@lancelotsix.com> wrote:
>
> Hi,
>
> Thanks for working on this!  I think I got used to use the "shift" key
> when I try to select, but soon might soon have "set tui mouse-events
> off" in my rc file.

I'm glad to hear my patch is useful to someone else!

I didn't know about the shift trick until *after* I submitted this patch. 😳

On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX <lsix@lancelotsix.com> wrote:
>   -  In GDB codebase, we use tab for indentation[1]:
>
>       Lines should be indented with a mix of tabs and spaces.  8 spaces
>       should be replaced with Tab.
>
>       It looks like you patch uses spaces for indentation.

That's probably an issue with my mail client. The email attachment
patch file should have the proper tabs.

On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX <lsix@lancelotsix.com> wrote:
>   -GDB prefers "nullptr" instead of "NULL".

I copied NULL from some other code in gdb, but I can change it if needed.