From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +naWKm6a22OmACgAWB0awg (envelope-from ) for ; Thu, 02 Feb 2023 06:11:42 -0500 Received: by simark.ca (Postfix, from userid 112) id A07751E128; Thu, 2 Feb 2023 06:11:42 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=WqYcZGS2; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 469A61E112 for ; Thu, 2 Feb 2023 06:11:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 98F5F3858C30 for ; Thu, 2 Feb 2023 11:11:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 98F5F3858C30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675336301; bh=rMr2zm2JxhsOUD0vK8grbb3LocAoWd3Y/tHai0N/moM=; h=References:In-Reply-To:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=WqYcZGS2FOkFAcN19Pvo4Citu2gwJUME7NMTOTf072tfXbEEwMS0RSdk46rxYHJJI ysLLYdQw9KyEU6rtTA7hv6FILXFXJQfph24GR0TIqj2jo9vQqR3vwXaKfFQxn1zIvu I2tBze1wYIo/9LwwQxJIWqArbwlL60z8Emt0VDPE= Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id 0EAA2385828E for ; Thu, 2 Feb 2023 11:11:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EAA2385828E Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-163adf0cfc4so1963318fac.7 for ; Thu, 02 Feb 2023 03:11:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rMr2zm2JxhsOUD0vK8grbb3LocAoWd3Y/tHai0N/moM=; b=vJ9DjAm8Lg7VjyOjrcD/NFfswhOcVYCGNwsPy2qyXMDst7A/5qP91LIeasOBtYCCfU DDsOfqZY/Qerj6DjWQH2ByD6tkJ2PLYKdcx3eRcTHMvwNaOknk//w5bb6wLz7Pr/jYIi esF1XizpNBSgSEaMwRntCKK3T47+ssOch45n8uyPz8Z6xaJ6jwQ5nOp5UqzCnG4CFvRw 6WvXZMv75WXMW7FpO6cOz5mUZEof5YesxsMV5HW8DYzrjkS+e7y7rfnx0zrpEN791oH+ zsAuCVIzCOEpixFH72nIbsraa5D8sswwRtE3nNDhkFWCSLfpqrlOAvgqVI8y2riwD7Z3 mbcQ== X-Gm-Message-State: AO0yUKVM5W5Jl1TQYpg+etiiGjjjzan32OHBvY/gDqpd0HWrqYwCc0WU fKTghIKyXZf3zYn2SPnr5f6b8WtuZS1G/4N5vSnYm0JHbXM= X-Google-Smtp-Source: AK7set9HH3jC6dFSmy5iiQvynCryg47DX8Zq/SBmj/2+EtViJM6lGAeY5oZAeQ7JP0GbrYRQ1tSvyHPZcCsTcE7yZQc= X-Received: by 2002:a05:6870:3048:b0:15f:d0bb:fa63 with SMTP id u8-20020a056870304800b0015fd0bbfa63mr285369oau.3.1675336281183; Thu, 02 Feb 2023 03:11:21 -0800 (PST) MIME-Version: 1.0 References: <20230202092950.tpxei5w4meutjeiv@ubuntu.lan> In-Reply-To: <20230202092950.tpxei5w4meutjeiv@ubuntu.lan> Date: Thu, 2 Feb 2023 03:11:10 -0800 Message-ID: Subject: Re: [PATCH] gdb/tui: add 'set tui mouse-events off' to restore mouse selection To: Lancelot SIX Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: strager via Gdb-patches Reply-To: strager Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX wrote: > > Hi, > > Thanks for working on this! I think I got used to use the "shift" key > when I try to select, but soon might soon have "set tui mouse-events > off" in my rc file. I'm glad to hear my patch is useful to someone else! I didn't know about the shift trick until *after* I submitted this patch. = =F0=9F=98=B3 On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX wrote: > - In GDB codebase, we use tab for indentation[1]: > > Lines should be indented with a mix of tabs and spaces. 8 spaces > should be replaced with Tab. > > It looks like you patch uses spaces for indentation. That's probably an issue with my mail client. The email attachment patch file should have the proper tabs. On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX wrote: > -GDB prefers "nullptr" instead of "NULL". I copied NULL from some other code in gdb, but I can change it if needed.