From: Fam Zheng <fam@euphon.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Simon Marchi <simark@simark.ca>,
Andreas Schwab <schwab@linux-m68k.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v6 3/3] disass: Add texinfo doc for the /x modifier
Date: Sat, 26 Sep 2020 08:49:42 +0000 [thread overview]
Message-ID: <CABgc4wQUFu-=zHL0RO4E-=gYAe5GcVKSWUL=MPNeAip0sSLH8A@mail.gmail.com> (raw)
In-Reply-To: <831riprlxd.fsf@gnu.org>
On Sat, Sep 26, 2020 at 8:18 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: fam@euphon.net
> > Cc: Simon Marchi <simark@simark.ca>,
> > Pedro Alves <pedro@palves.net>,
> > Andrew Burgess <andrew.burgess@embecosm.com>,
> > Andreas Schwab <schwab@linux-m68k.org>,
> > fam@euphon.net,
> > Eli Zaretskii <eliz@gnu.org>
> > Date: Sat, 26 Sep 2020 08:35:39 +0100
> >
> > From: Fam Zheng <famzheng@amazon.com>
> >
> > gdb/doc/ChangeLog:
> >
> > 2020-09-25 Fam Zheng <famzheng@amazon.com>
> >
> > * gdb.texinfo (disassemble): Document /x modifier of disass
> > command.
>
> The name of that node is "Machine Code", not "disassemble". You can
> see the name by looking backward for a @node directive. Or just use
> Emacs's add-change-log-entry-* commands, they will do that for you.
OK, no problem, it should be easy to fix. I just looked at git blame
in the context and copied 9b117ef31f which did the same. But I think
you're right.
I don't use Emacs, so I cannot take that benefit. :(
Thanks for the review and quick response!
Fam
prev parent reply other threads:[~2020-09-26 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 7:35 [PATCH v6 0/3] disass: Add " fam
2020-09-26 7:35 ` [PATCH v6 1/3] disass: Add /x modifier to print offsets in hex fam
2020-09-26 7:35 ` [PATCH v6 2/3] disass: Add test for /x mode fam
2020-09-26 7:35 ` [PATCH v6 3/3] disass: Add texinfo doc for the /x modifier fam
2020-09-26 8:18 ` Eli Zaretskii via Gdb-patches
2020-09-26 8:49 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABgc4wQUFu-=zHL0RO4E-=gYAe5GcVKSWUL=MPNeAip0sSLH8A@mail.gmail.com' \
--to=fam@euphon.net \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox