From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tjYPC90Ab1+OOwAAWB0awg (envelope-from ) for ; Sat, 26 Sep 2020 04:50:37 -0400 Received: by simark.ca (Postfix, from userid 112) id 1647D1EF4D; Sat, 26 Sep 2020 04:50:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 42D621E509 for ; Sat, 26 Sep 2020 04:50:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A930B385703A; Sat, 26 Sep 2020 08:50:33 +0000 (GMT) Received: from sender2-op-o12.zoho.com.cn (sender2-op-o12.zoho.com.cn [163.53.93.243]) by sourceware.org (Postfix) with ESMTPS id 9BAE1385703A for ; Sat, 26 Sep 2020 08:50:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9BAE1385703A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=euphon.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fam@euphon.net ARC-Seal: i=1; a=rsa-sha256; t=1601110225; cv=none; d=zoho.com.cn; s=zohoarc; b=BJpMCQ38wyYCDwRVIOpQNFb9R1YDkDjf7x18i8mz821hHM5liuKhzX1KA/PWbofQchqm/zop7RMI2Dl7y6A2A1l6nKx1LBpnpz+/qKVQHlcEfXW9WR59FWQoyqEfZP9/cJkwKmiHdBRzfpxqLff9jFUhC3+GR6BsBHGnLC4EH9k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1601110225; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Lp/fOndVeHwqdLGtf2mE2CgJrjlH19we/lWo2yxYQ7s=; b=oUyeQ3KSPwyKRPtU3pH/aY6Ipx8oc693u/4+wY+tDsAs+WYfxOnPmZrLyZuOYTQtDl5nAdJw++54ZYG5kIH47GDp1ZxCFZ8mAd1NWfF30lWDRWMclm4Kha9iv6B/zdxriSJl3qbUXR0dYxCozcHJniK20hK2WZ5Zr9F/LWUWags= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=euphon.net; spf=pass smtp.mailfrom=fam@euphon.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1601110225; s=zoho; d=euphon.net; i=fam@euphon.net; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Content-Type; bh=Lp/fOndVeHwqdLGtf2mE2CgJrjlH19we/lWo2yxYQ7s=; b=ESHX2ElYGu0pOeHH1EhLFohrGDX4SRagWDTY+YirAGmwaWUihlmQHWE8U9e1djVp MrTokIIkK1J5dxiXaYMjdttNJIPs09knb1xKuNbDX2vT/Pc+pzpUFEGskS4nw0iLSOi cWJq3pvzCx9Qn0K1OZtPJp9SsNQI5OmmbT5eVZ0k= Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mx.zoho.com.cn with SMTPS id 1601110222912575.1117727805406; Sat, 26 Sep 2020 16:50:22 +0800 (CST) Received: by mail-lj1-f170.google.com with SMTP id w3so4373504ljo.5 for ; Sat, 26 Sep 2020 01:50:21 -0700 (PDT) X-Gm-Message-State: AOAM533EVAVpfqnPEC6A83w7KMZ4J0jUQmEHBdlMQpuqdV/Pdc8Nk1YB 1NzHQOnGdH8YAm0K5GRzAwMj0nyyi3onEbWq+vU= X-Google-Smtp-Source: ABdhPJzNbWv2EKGe+B6LXrFktP0Qs07d3MnP4Uouek2ZvHKX+m37xlDzOKhxBwyRbRdawT1BW2zlm4ba/5NWzInp8S8= X-Received: by 2002:a2e:86d3:: with SMTP id n19mr2659420ljj.368.1601110217957; Sat, 26 Sep 2020 01:50:17 -0700 (PDT) MIME-Version: 1.0 References: <20200926073539.981936-1-fam@euphon.net> <20200926073539.981936-4-fam@euphon.net> <831riprlxd.fsf@gnu.org> In-Reply-To: <831riprlxd.fsf@gnu.org> From: Fam Zheng Date: Sat, 26 Sep 2020 08:49:42 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 3/3] disass: Add texinfo doc for the /x modifier To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-ZohoCNMailClient: External X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi , Andreas Schwab , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Sat, Sep 26, 2020 at 8:18 AM Eli Zaretskii wrote: > > > From: fam@euphon.net > > Cc: Simon Marchi , > > Pedro Alves , > > Andrew Burgess , > > Andreas Schwab , > > fam@euphon.net, > > Eli Zaretskii > > Date: Sat, 26 Sep 2020 08:35:39 +0100 > > > > From: Fam Zheng > > > > gdb/doc/ChangeLog: > > > > 2020-09-25 Fam Zheng > > > > * gdb.texinfo (disassemble): Document /x modifier of disass > > command. > > The name of that node is "Machine Code", not "disassemble". You can > see the name by looking backward for a @node directive. Or just use > Emacs's add-change-log-entry-* commands, they will do that for you. OK, no problem, it should be easy to fix. I just looked at git blame in the context and copied 9b117ef31f which did the same. But I think you're right. I don't use Emacs, so I cannot take that benefit. :( Thanks for the review and quick response! Fam