From: 紀重禕 <demonic@csie.io>
To: gdb-patches@sourceware.org
Subject: [PATCH] gdb/riscv: fix recorded insn type
Date: Thu, 17 Sep 2020 10:14:05 +0800 [thread overview]
Message-ID: <CA+YVB3RzggCoDf5i8bPdAd2zKN+UkcmC6VzA4DhaGx4LFCpZJQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]
Hi, I fixed the instruction type in the decoding method.
---
gdb/ChangeLog | 3 +++
gdb/riscv-tdep.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 84ee292750..5bf0c8ff14 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,6 @@
+2020-09-17 Chungyi Chi <demonic@csie.io>
+ * riscv-tdep.c (riscv-insn::decode): Fix recorded insn type.
+
2020-09-16 Simon Marchi <simon.marchi@efficios.com>
* breakpoint.h (init_catchpoint): Change int parameter to bool.
diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
index a7c25642d0..ac4ac1b6fd 100644
--- a/gdb/riscv-tdep.c
+++ b/gdb/riscv-tdep.c
@@ -1472,7 +1472,7 @@ riscv_insn::decode (struct gdbarch *gdbarch,
CORE_ADDR pc)
else if (is_c_swsp_insn (ival))
decode_css_type_insn (SW, ival, EXTRACT_RVC_SWSP_IMM (ival));
else if (xlen != 4 && is_c_sdsp_insn (ival))
- decode_css_type_insn (SW, ival, EXTRACT_RVC_SDSP_IMM (ival));
+ decode_css_type_insn (SD, ival, EXTRACT_RVC_SDSP_IMM (ival));
/* C_JR and C_MV have the same opcode. If RS2 is 0, then this is a
C_JR.
So must try to match C_JR first as it ahs more bits in mask. */
else if (is_c_jr_insn (ival))
--
2.25.0
[-- Attachment #2: 0001-gdb-riscv-fix-recorded-insn-type.patch --]
[-- Type: application/octet-stream, Size: 1362 bytes --]
From 459edc7cdd39a8df57747966af755744fd17faaa Mon Sep 17 00:00:00 2001
From: Chungyi Chi <demonic@csie.io>
Date: Thu, 17 Sep 2020 01:59:26 +0000
Subject: [PATCH] gdb/riscv: fix recorded insn type
---
gdb/ChangeLog | 3 +++
gdb/riscv-tdep.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 84ee292750..5bf0c8ff14 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,6 @@
+2020-09-17 Chungyi Chi <demonic@csie.io>
+ * riscv-tdep.c (riscv-insn::decode): Fix recorded insn type.
+
2020-09-16 Simon Marchi <simon.marchi@efficios.com>
* breakpoint.h (init_catchpoint): Change int parameter to bool.
diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
index a7c25642d0..ac4ac1b6fd 100644
--- a/gdb/riscv-tdep.c
+++ b/gdb/riscv-tdep.c
@@ -1472,7 +1472,7 @@ riscv_insn::decode (struct gdbarch *gdbarch, CORE_ADDR pc)
else if (is_c_swsp_insn (ival))
decode_css_type_insn (SW, ival, EXTRACT_RVC_SWSP_IMM (ival));
else if (xlen != 4 && is_c_sdsp_insn (ival))
- decode_css_type_insn (SW, ival, EXTRACT_RVC_SDSP_IMM (ival));
+ decode_css_type_insn (SD, ival, EXTRACT_RVC_SDSP_IMM (ival));
/* C_JR and C_MV have the same opcode. If RS2 is 0, then this is a C_JR.
So must try to match C_JR first as it ahs more bits in mask. */
else if (is_c_jr_insn (ival))
--
2.25.0
next reply other threads:[~2020-09-17 2:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 2:14 紀重禕 [this message]
2020-09-17 8:49 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+YVB3RzggCoDf5i8bPdAd2zKN+UkcmC6VzA4DhaGx4LFCpZJQ@mail.gmail.com \
--to=demonic@csie.io \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox