From: 紀重禕 <demonic@csie.io>
To: simark@simark.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] breakpoint.c: Fix advance/until and multiple locations
Date: Thu, 27 Aug 2020 10:17:47 +0800 [thread overview]
Message-ID: <CA+YVB3QeT0n54--JLtjvumMt3xHiZ=HLEgi0SRvg0SBQ2rYfGQ@mail.gmail.com> (raw)
In-Reply-To: <27c4a444-3b72-3b00-ec23-5e6e9082d5e7@simark.ca>
Hi Simon,
Pedro Alves actually did a better and complete patch! Sorry to take up your
time.
Simon Marchi <simark@simark.ca> 於 2020年8月27日 週四 上午10:03寫道：
> On 2020-08-26 11:06 a.m., 紀重禕 wrote:
> > Fix bug 26524 <https://sourceware.org/bugzilla/show_bug.cgi?id=26524> ,
> > iterate the sals variable to insert a breakpoint for each <location>
> >
> > --
> > Best regards,
> > Chung-Yi Chi
> >
>
> Hi,
>
> I'm not sure the approach is right, since you end up creating multiple
> until_break_fsm
> objects (one for each sal) and overwriting them.
>
> Pedro Alves posted some patches fixing the same problem here:
>
> https://sourceware.org/pipermail/gdb-patches/2020-August/171427.html
>
> which look good to me. Could you please take a look at those?
>
> Simon
>
--
Best regards,
Chung-Yi Chi
next prev parent reply other threads:[~2020-08-27 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 15:06 紀重禕
2020-08-27 2:03 ` Simon Marchi
2020-08-27 2:17 ` 紀重禕 [this message]
2020-08-27 2:22 ` Simon Marchi
2020-08-27 20:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+YVB3QeT0n54--JLtjvumMt3xHiZ=HLEgi0SRvg0SBQ2rYfGQ@mail.gmail.com' \
--to=demonic@csie.io \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox