From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by sourceware.org (Postfix) with ESMTPS id A9AC23857C47 for ; Thu, 27 Aug 2020 02:18:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A9AC23857C47 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=csie.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=demonic@csie.io Received: by mail-lj1-x242.google.com with SMTP id g6so4627566ljn.11 for ; Wed, 26 Aug 2020 19:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=csie-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hw8vBW4B733maQS1+5UV8md8/SOvGx6ZNRE03/xd8cg=; b=uZ0Qc6lDfFzqIMVJA0qKxe63aCUEJW9TrtMKgWeX6arUqewajzcsaTv4zIeT/PmNOO QWJTSCs6W89T/xwPvMducSsIsJ771CAQntsyGq0dKMVA5XJmsG5k8uHiptGyHknpmIEo RSx8+DrCOCQUfCNNgTMO6VKU/fPzbXZ3WpUZUqNKkAtegI/eQldGPQFCfShbKr1819kd vP63WNHvCDA6uvDKRTdCHSyQJ+oiu+di3gHt1h7pcUZW6dwfepf5ggQsu8dDSCAJ+PVt boQR2t/zNjXBMutsJubRmZ3DaJoRJ1od1cXkTV6mIzdwj9lya3bo484i9QLqgKEQEqBr Xsfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hw8vBW4B733maQS1+5UV8md8/SOvGx6ZNRE03/xd8cg=; b=knXm6WoJ5EnenWv8d48RR/iouJ8kqU+qLNwg/rIjmKpwQt83AJHW1axm1Pj0+666aV kIXzek3MCFj89ZgapLkS2hlLYmH96oJG68QLwxhynDUTu1e+9GI3trjtISiWUK+f5Y6h oxdCzHgE5WUDhkZx82+ooiebY0DwpNydImA0m+D9+JAE3HVGz+Ke17AeYT41rzjsaW/y sA6lCI8NnuFOGUAqazSjRcDl96GqRJdfR7i9iNPcMQrp/qxG6d72leE5R3/Bf53dclZq QwZIE+bc1hKdwnehAKJF5gPVwgyp1+kbf67fGOsszAKW0iLvUFrvIzbp3daoNo4e+6fY RGfA== X-Gm-Message-State: AOAM530X5xTHfSvgj6mnXoHV5xLPrSmf6reMHvSJiKqolP0KtJnK1PL2 9Ap8ooBEHY+XNUem8NFyqzaOUYpOfzdWsEvSWW+prk24Q6wWUYY+ X-Google-Smtp-Source: ABdhPJz+li61KIQx0N2Nw2bMV4rDnQx5jvjxCEbatV+yFgi+/KMbyqPGMQA0F9zHG1QTJ/Rba0+aS26nxxnimpPjDt4= X-Received: by 2002:a05:651c:8f:: with SMTP id 15mr7716458ljq.53.1598494703408; Wed, 26 Aug 2020 19:18:23 -0700 (PDT) MIME-Version: 1.0 References: <27c4a444-3b72-3b00-ec23-5e6e9082d5e7@simark.ca> In-Reply-To: <27c4a444-3b72-3b00-ec23-5e6e9082d5e7@simark.ca> From: =?UTF-8?B?57SA6YeN56aV?= Date: Thu, 27 Aug 2020 10:17:47 +0800 Message-ID: Subject: Re: [PATCH] breakpoint.c: Fix advance/until and multiple locations To: simark@simark.ca Cc: gdb-patches@sourceware.org X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 02:18:26 -0000 Hi Simon, Pedro Alves actually did a better and complete patch! Sorry to take up your time. Simon Marchi =E6=96=BC 2020=E5=B9=B48=E6=9C=8827=E6=97= =A5 =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=8810:03=E5=AF=AB=E9=81=93=EF=BC=9A > On 2020-08-26 11:06 a.m., =E7=B4=80=E9=87=8D=E7=A6=95 wrote: > > Fix bug 26524 = , > > iterate the sals variable to insert a breakpoint for each > > > > -- > > Best regards, > > Chung-Yi Chi > > > > Hi, > > I'm not sure the approach is right, since you end up creating multiple > until_break_fsm > objects (one for each sal) and overwriting them. > > Pedro Alves posted some patches fixing the same problem here: > > https://sourceware.org/pipermail/gdb-patches/2020-August/171427.html > > which look good to me. Could you please take a look at those? > > Simon > --=20 Best regards, Chung-Yi Chi