Re: Optionally print source code to gdb console window

[Robert Rossi <bob@brasko.net>]

[-- Attachment #1: Type: text/plain, Size: 2761 bytes --]

Hi Tom,

Thanks for the feedback. This is wrong in a few directions unfortunately.

The first is that the output looks like this in the suggested case,
(gdb) n
43      in test_main.cpp
(gdb)
44      in test_main.cpp
(gdb) n
47      in test_main.cpp
(gdb) list
42      in test_main.cpp

Which is not what the user wants. They don't want to see the updates in the
console
regarding source positions.
In addition, you can see capabilities they may want, 'list', no longer work.

The reason this issue was noticed in the first place is because this was the
vision of the original gdb maintainers when using annotate=2. In that mode,
no source code would be printed to the console. However, in mi new-ui mode
gdb does print the source code to the console.

My personal opinion is that gdb shouldn't print code to the console in mi
mode
or in new-ui mode. However, there were some people from eclipse a few years
ago that said they disagreed and that gdb should behave identical in new-ui
mode and not in new-ui mode, so i've attempted to make an option.

I'm happy to add docs and a test case.
Can you give me some pointers on how the implementation should change?

I should also ask, is an option even necessary?
I think if we remove the source printing from the console when in new-ui
mode
or in mi-mode it would make the most sense. After all, there is a front end
displaying
this information, no?

Thanks,
Bob Rossi

On Tue, May 7, 2024 at 12:52 PM Tom Tromey <tom@tromey.com> wrote:

> >>>>> "Robert" == Robert Rossi <bob@brasko.net> writes:
>
> Thank you for the patch.
>
> Robert> A little history. When using --annotations, gdb did not print
> Robert> the source code to the gdb console window. When using mi with
> Robert> new-ui it does.  When I reported this in the past, several
> Robert> people said it was a feature that gdb printed the source code
> Robert> lines to the console.
>
> Robert> I've had several users of cgdb say they do not want gdb to print
> Robert> the source code to the gdb console window as they can see the
> Robert> code in the code view.
>
> Robert> I've created and attached a patch that I hope makes it optional
> Robert> to have gdb print the source code to the gdb console
> Robert> window. Could I have some feedback?
>
> I was reviewing your patch and I found is a pre-existing setting that
> claims to do what you want: "set source open off".
>
> Could you try this and see if it works?  I suspect this is the way to
> go.
>
> Otherwise, we can look at your patch.  From a first read, I think the
> idea is totally fine, but the implementation would need to be changed.
> Also it would need documentation and a test case.
>
> thanks,
> Tom
>

[-- Attachment #2: Type: text/html, Size: 3601 bytes --]