Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Robert Rossi <bob@brasko.net>
Cc: gdb-patches@sourceware.org
Subject: Re: Optionally print source code to gdb console window
Date: Tue, 07 May 2024 10:52:09 -0600	[thread overview]
Message-ID: <87ikzpa7k6.fsf@tromey.com> (raw)
In-Reply-To: <CA+L9JkjGv1J546wQScPSnTVzqM7ai65Ye4XQELqMkSBdabTKKg@mail.gmail.com> (Robert Rossi's message of "Sun, 5 May 2024 16:57:00 -0400")

>>>>> "Robert" == Robert Rossi <bob@brasko.net> writes:

Thank you for the patch.

Robert> A little history. When using --annotations, gdb did not print
Robert> the source code to the gdb console window. When using mi with
Robert> new-ui it does.  When I reported this in the past, several
Robert> people said it was a feature that gdb printed the source code
Robert> lines to the console.

Robert> I've had several users of cgdb say they do not want gdb to print
Robert> the source code to the gdb console window as they can see the
Robert> code in the code view.

Robert> I've created and attached a patch that I hope makes it optional
Robert> to have gdb print the source code to the gdb console
Robert> window. Could I have some feedback?

I was reviewing your patch and I found is a pre-existing setting that
claims to do what you want: "set source open off".

Could you try this and see if it works?  I suspect this is the way to
go.

Otherwise, we can look at your patch.  From a first read, I think the
idea is totally fine, but the implementation would need to be changed.
Also it would need documentation and a test case.

thanks,
Tom

  parent reply	other threads:[~2024-05-07 16:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-05 20:57 Robert Rossi
2024-05-06 22:18 ` Robert Rossi
2024-05-07 16:52 ` Tom Tromey [this message]
2024-05-07 21:33   ` Robert Rossi
2024-05-08  0:52     ` Tom Tromey
2024-05-08  1:29       ` Bob Rossi
2024-05-08 15:46         ` Tom Tromey
2024-05-08 23:07           ` Bob Rossi
2024-05-09 13:58             ` Tom Tromey
2024-05-10 10:19             ` Andrew Burgess
2024-05-10 18:07               ` Tom Tromey
2024-05-10 19:29           ` Pedro Alves
2024-05-10 19:23     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikzpa7k6.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=bob@brasko.net \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox