From: Patrick Palka <patrick@parcs.ath.cx>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Have SIGTERM promptly quit GDB even when the dummy target is active
Date: Mon, 27 Jul 2015 15:44:00 -0000 [thread overview]
Message-ID: <CA+C-WL_+z8EUXfOJFr9qA+PBj+k0V7rTKZ1Qx0yyYU9H0O+0uA@mail.gmail.com> (raw)
In-Reply-To: <55B64C5E.8060009@redhat.com>
On Mon, Jul 27, 2015 at 11:21 AM, Pedro Alves <palves@redhat.com> wrote:
> On 07/27/2015 03:53 PM, Pedro Alves wrote:
>> On 07/24/2015 07:33 PM, Patrick Palka wrote:
>>
>>> gdb/ChangeLog:
>>>
>>> * event-top.c (handle_sigterm): Don't inspect
>>> target_can_async_p. Always set the quit flag and always mark
>>> the async signal handler.
>>
>> OK.
>
> BTW, I notice that GDB leaves the terminal settings broken
> after exiting on SIGTERM. Is that something you're already
> looking at? (Mostly likely there's a target_terminal_ours
> missing somewhere.)
I think we should do target_terminal_ours in quit_force. (A similar
problem also exists in our SIGWINCH handler.)
next prev parent reply other threads:[~2015-07-27 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 18:33 Patrick Palka
2015-07-27 14:53 ` Pedro Alves
2015-07-27 15:21 ` Pedro Alves
2015-07-27 15:44 ` Patrick Palka [this message]
2015-07-27 15:26 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL_+z8EUXfOJFr9qA+PBj+k0V7rTKZ1Qx0yyYU9H0O+0uA@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox