Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Patrick Palka <patrick@parcs.ath.cx>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Have SIGTERM promptly quit GDB even when the dummy target is active
Date: Mon, 27 Jul 2015 15:26:00 -0000	[thread overview]
Message-ID: <CA+C-WL8PtO8w5SSvd8qq__DJZV5Ls8gRUwjrz+MxQn+eka_BVQ@mail.gmail.com> (raw)
In-Reply-To: <55B645E1.7060809@redhat.com>

On Mon, Jul 27, 2015 at 10:53 AM, Pedro Alves <palves@redhat.com> wrote:
> On 07/24/2015 07:33 PM, Patrick Palka wrote:
>
>> gdb/ChangeLog:
>>
>>       * event-top.c (handle_sigterm): Don't inspect
>>       target_can_async_p.  Always set the quit flag and always mark
>>       the async signal handler.
>
> OK.
>
>> +gdb_start
>> +
>> +set gdb_pid [exp_pid -i [board_info host fileid]]
>> +remote_exec host "kill -TERM $gdb_pid"
>> +
>> +set test "expect eof"
>> +
>> +gdb_expect 5 {
>
> Any reason not to use gdb_test_multiple, like:
>
>  gdb_test_multiple "" $test {
>    -timeout 5
>    eof {
>       pass $test
>    }
>  }
>
> ?

No reason.  I'll change the test to use gdb_test_multiple and commit the patch.


      parent reply	other threads:[~2015-07-27 15:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 18:33 Patrick Palka
2015-07-27 14:53 ` Pedro Alves
2015-07-27 15:21   ` Pedro Alves
2015-07-27 15:44     ` Patrick Palka
2015-07-27 15:26   ` Patrick Palka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+C-WL8PtO8w5SSvd8qq__DJZV5Ls8gRUwjrz+MxQn+eka_BVQ@mail.gmail.com \
    --to=patrick@parcs.ath.cx \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox