From: Patrick Palka <patrick@parcs.ath.cx>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Fix C++ virtual method pointer resolution
Date: Fri, 21 Nov 2014 13:51:00 -0000 [thread overview]
Message-ID: <CA+C-WL8_uAKxZ3GE-vdvJUfNC2e7uHM0tHZqWM78q+0DVo8Yvg@mail.gmail.com> (raw)
In-Reply-To: <87389cfze2.fsf@codesourcery.com>
On Fri, Nov 21, 2014 at 8:37 AM, Yao Qi <yao@codesourcery.com> wrote:
> Patrick Palka <patrick@parcs.ath.cx> writes:
>
>>>> +get_debug_format
>>>> +
>>>> +if ![test_debug_format "DWARF 2"] {
>>>> + return 0
>>>> +}
>>>
>>> Why do we need to check test_debug_format here?
>>
>> Because GDB only supports C++ method pointers with the DWARF debug
>> format. So I'd assume that this test would fail for non-DWARF.
>
> I am not aware of this, any details? If GDB doesn't support C++ method
> pointers with non-DWARF, we should kfail or xfail it in the test. See
> gdb.cp/m-static.exp.
Err, sorry, I conflated the ABI (gnu-v3) with the debug format
(DWARF). That hunk is unnecessary.
next prev parent reply other threads:[~2014-11-21 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 3:07 Patrick Palka
2014-09-30 21:49 ` Patrick Palka
2014-11-16 3:57 ` Patrick Palka
2014-11-21 11:35 ` Yao Qi
2014-11-21 13:37 ` Patrick Palka
2014-11-21 13:37 ` Yao Qi
2014-11-21 13:51 ` Patrick Palka [this message]
2014-11-21 14:53 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL8_uAKxZ3GE-vdvJUfNC2e7uHM0tHZqWM78q+0DVo8Yvg@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox