From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-117727-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18811 invoked by alias); 21 Nov 2014 13:51:59 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18800 invoked by uid 89); 21 Nov 2014 13:51:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2
X-HELO: mail-pd0-f180.google.com
Received: from mail-pd0-f180.google.com (HELO mail-pd0-f180.google.com) (209.85.192.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 21 Nov 2014 13:51:54 +0000
Received: by mail-pd0-f180.google.com with SMTP id p10so5307391pdj.25        for <gdb-patches@sourceware.org>; Fri, 21 Nov 2014 05:51:52 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc:content-type;        bh=ZEDCFGKYfEks8g2bR5AAlj3dOM5MEo1T61Elupav8WM=;        b=BVa3F3F+mHCQcwbTnwTrrCjPvpmy6RFfNJN3LEpb+lwT0AFpxhxYrsfpN1cyhTcsmR         IkrJazSiXePx3gf3bWapZofTJkT7OvF0KASX8v/GrsEV9T9VSMixgjNvSIsetpxnq4AU         RpmGLAeuTknSdZ3lpyvFpKnFdICpHdVXaFlkcxumDd9IgT/f/gbmpZkr2HumVn5Y9vST         l08BPIprQCGFPWVGAhDtnElDsObxRhYgXmDFkL7AZ+K1yLqkWISTERpfAIM2oxIzG+Zt         pUHwiyfw+4m4SL8pKDJlwVzXH/YpDpMG1lxgTXj0B/Jph824g/F871X+W0xhF0vYVRyH         A/zQ==
X-Gm-Message-State: ALoCoQlsAM6TxHAcNXNnfH7cBQvKWnU3DPzmAby5POMHLucQ66OcZNwMHrgiloo5H5lknRe4q0GQ
X-Received: by 10.68.143.226 with SMTP id sh2mr7479814pbb.62.1416577455396; Fri, 21 Nov 2014 05:44:15 -0800 (PST)
MIME-Version: 1.0
Received: by 10.70.31.100 with HTTP; Fri, 21 Nov 2014 05:43:55 -0800 (PST)
In-Reply-To: <87389cfze2.fsf@codesourcery.com>
References: <1411355243-10812-1-git-send-email-patrick@parcs.ath.cx> <87k32og51t.fsf@codesourcery.com> <CA+C-WL8r=1mW=P0PxioLgfhS8pJsXkQb7Sm7iD3q4i-i3Cyhvg@mail.gmail.com> <87389cfze2.fsf@codesourcery.com>
From: Patrick Palka <patrick@parcs.ath.cx>
Date: Fri, 21 Nov 2014 13:51:00 -0000
Message-ID: <CA+C-WL8_uAKxZ3GE-vdvJUfNC2e7uHM0tHZqWM78q+0DVo8Yvg@mail.gmail.com>
Subject: Re: [PATCH 1/2] Fix C++ virtual method pointer resolution
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-11/txt/msg00519.txt.bz2

On Fri, Nov 21, 2014 at 8:37 AM, Yao Qi <yao@codesourcery.com> wrote:
> Patrick Palka <patrick@parcs.ath.cx> writes:
>
>>>> +get_debug_format
>>>> +
>>>> +if ![test_debug_format "DWARF 2"] {
>>>> +    return 0
>>>> +}
>>>
>>> Why do we need to check test_debug_format here?
>>
>> Because GDB only supports C++ method pointers with the DWARF debug
>> format. So I'd assume that this test would fail for non-DWARF.
>
> I am not aware of this, any details?  If GDB doesn't support C++ method
> pointers with non-DWARF, we should kfail or xfail it in the test.  See
> gdb.cp/m-static.exp.

Err, sorry, I conflated the ABI (gnu-v3) with the debug format
(DWARF). That hunk is unnecessary.