From: Patrick Palka <patrick@parcs.ath.cx>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add missing leading space to some queries
Date: Wed, 28 Oct 2015 20:34:00 -0000 [thread overview]
Message-ID: <CA+C-WL-UHW7ANnJ_BV4d0TdFzvumC_hULAt9N7ODZMjksXD_dQ@mail.gmail.com> (raw)
In-Reply-To: <56310170.1090607@redhat.com>
On Wed, Oct 28, 2015 at 1:10 PM, Pedro Alves <palves@redhat.com> wrote:
> On 10/28/2015 04:20 PM, Patrick Palka wrote:
>> Query strings should have a leading space so that there is some kind of
>> separator between the actual query and the "(y or n)" suffix that is
>> appended to the query.
>>
>
> OK.
>
> Though, it would seem better to me to go the other way around and have
> query() itself add the space. E.g. the way it is, translations would
> need to know that the space is there to keep, which seems fragile.
That makes sense. I'll post a patch tomorrow that does this instead.
>
> Thanks,
> Pedro Alves
>
prev parent reply other threads:[~2015-10-28 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 19:29 Patrick Palka
2015-10-28 19:59 ` Pedro Alves
2015-10-28 20:34 ` Patrick Palka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL-UHW7ANnJ_BV4d0TdFzvumC_hULAt9N7ODZMjksXD_dQ@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox