From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44684 invoked by alias); 28 Oct 2015 17:20:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44667 invoked by uid 89); 28 Oct 2015 17:20:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-oi0-f41.google.com Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 28 Oct 2015 17:20:46 +0000 Received: by oiad129 with SMTP id d129so8675768oia.0 for ; Wed, 28 Oct 2015 10:20:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=MsLMndG6HYvnFTlLjr1J6g6UUtgf+oFx5QIqTaXya7Y=; b=L9WXcW6UeAVJljMJRnJhasw7/Ex6KdK7UhKf0Gc9NlFNjpdhQQL/UyxQRC4GvoWRdq F8h+1NqCG2BH6D5zrA/q/FbGOFiA3VZX/8d6MZXiKDr53+bZ2cSHg0B6q2p2+K00maKp ZgGojuZ0KhppZOrUogDQdkarMLXyp2kRFJteNu8/KwVDTpzgbkU29mxUqHmpc8s9/nK+ E2SHvWpHx368QcaleIiWGYTSfV5VYwD2zXwsQrmNoW6LXgWrCFQuI0AgAynFPFtpY1La mT+74y8dOXIldAQUxZy2a0vKoansy8eWXjPa/L4PSeAkAayX5mnu6UDbpzZfIKSI+hKa dIKw== X-Gm-Message-State: ALoCoQk+lVoeDvgW12nOG8I/10AdlN0F8VsknOuGTmSl6fA5mr011C36Dh0LUIFpWjOpw0O78kbG X-Received: by 10.202.190.10 with SMTP id o10mr10830453oif.23.1446052844240; Wed, 28 Oct 2015 10:20:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.216.70 with HTTP; Wed, 28 Oct 2015 10:20:24 -0700 (PDT) In-Reply-To: <56310170.1090607@redhat.com> References: <1446049232-2318-1-git-send-email-patrick@parcs.ath.cx> <56310170.1090607@redhat.com> From: Patrick Palka Date: Wed, 28 Oct 2015 20:34:00 -0000 Message-ID: Subject: Re: [PATCH] Add missing leading space to some queries To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-10/txt/msg00661.txt.bz2 On Wed, Oct 28, 2015 at 1:10 PM, Pedro Alves wrote: > On 10/28/2015 04:20 PM, Patrick Palka wrote: >> Query strings should have a leading space so that there is some kind of >> separator between the actual query and the "(y or n)" suffix that is >> appended to the query. >> > > OK. > > Though, it would seem better to me to go the other way around and have > query() itself add the space. E.g. the way it is, translations would > need to know that the space is there to keep, which seems fragile. That makes sense. I'll post a patch tomorrow that does this instead. > > Thanks, > Pedro Alves >