From: Patrick Palka <patrick@parcs.ath.cx>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Patrick Palka <patrick@parcs.ath.cx>
Subject: Re: [PATCH] Make sure to update registers if frame information has changed
Date: Wed, 01 Jul 2015 12:42:00 -0000 [thread overview]
Message-ID: <CA+C-WL-T0qBkmfgtuC4my0VoezfYtekbYZZ_DuO7atkXo7fH4w@mail.gmail.com> (raw)
In-Reply-To: <1435754216-31399-1-git-send-email-patrick@parcs.ath.cx>
On Wed, Jul 1, 2015 at 8:36 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> When I removed TUI's frame_changed hook to fix PR tui/13378 I assumed
> that there's no reason to refresh register information following a call
> to "up", "down" or "frame". This assumption was made to fix the problem
> of refreshing frame information twice following a sync-execution normal
> stop (once in tui_normal_stop and then in tui_before_prompt) -- the
> second refresh removing any highlights made by the first.
>
> I was wrong about that -- GDB's snapshot of register information is
> per-frame, and when the frame changes, registers do too (most
> prominently the %rip and %rsp registers). So e.g. GDB 7.8 would
> highlight such register changes after invoking "up", "down" or "frame",
> and current GDB does not.
>
> To fix this regression, I added another (sufficient) condition for
To be more precise, s/I added/this patch adds/
next prev parent reply other threads:[~2015-07-01 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 12:37 Patrick Palka
2015-07-01 12:42 ` Patrick Palka [this message]
2015-07-01 15:55 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL-T0qBkmfgtuC4my0VoezfYtekbYZZ_DuO7atkXo7fH4w@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox