From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112840 invoked by alias); 1 Jul 2015 12:42:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112824 invoked by uid 89); 1 Jul 2015 12:42:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 01 Jul 2015 12:42:45 +0000 Received: by obbkm3 with SMTP id km3so27204243obb.1 for ; Wed, 01 Jul 2015 05:42:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=hQfppt8q/Fopj+NqmLNmGjIE+YEP0D/jjEzmC0ztlaI=; b=HmSC4YR0YfUGXe0ERqJM7Ut7Okk/qXGrX7Tj9eYSYVvHOI3hYRYkEdr2tf2P5HpUoR 9hjRNw/XBw7DJ1lM3B+ayivTvLY5gZUcs1ucnr0/7fuhIRyF4b0XKvZFZYbZIYh7p0AG oMQ5YPz49f0h5gatR2MYDd1ej12y8310RkPdW5tVcYrAgq26Dxzg7P9wozSrCTCTkRcu SZydOUmZkxeQyg2g1HDL3rqkBX5Et2cs76XOdwn+J6mwFlNp9xnR3zFAp7Vxlo4mDu7X 8wVWBdrzL7PM/2T7pXMxTd2SoYrxI6H5R7NStrFWwAFs86KmvYA72geZaC+KYoi87Tuf BgNA== X-Gm-Message-State: ALoCoQkPtPmWR7RhxAjQKEnBiUSqzj0sGFJZMHwC5vCW722o/0pwZsFn4vVKAZELOThgIlfhIPw8 X-Received: by 10.60.47.113 with SMTP id c17mr24523485oen.64.1435754563663; Wed, 01 Jul 2015 05:42:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Wed, 1 Jul 2015 05:42:24 -0700 (PDT) In-Reply-To: <1435754216-31399-1-git-send-email-patrick@parcs.ath.cx> References: <1435754216-31399-1-git-send-email-patrick@parcs.ath.cx> From: Patrick Palka Date: Wed, 01 Jul 2015 12:42:00 -0000 Message-ID: Subject: Re: [PATCH] Make sure to update registers if frame information has changed To: "gdb-patches@sourceware.org" Cc: Patrick Palka Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg00022.txt.bz2 On Wed, Jul 1, 2015 at 8:36 AM, Patrick Palka wrote: > When I removed TUI's frame_changed hook to fix PR tui/13378 I assumed > that there's no reason to refresh register information following a call > to "up", "down" or "frame". This assumption was made to fix the problem > of refreshing frame information twice following a sync-execution normal > stop (once in tui_normal_stop and then in tui_before_prompt) -- the > second refresh removing any highlights made by the first. > > I was wrong about that -- GDB's snapshot of register information is > per-frame, and when the frame changes, registers do too (most > prominently the %rip and %rsp registers). So e.g. GDB 7.8 would > highlight such register changes after invoking "up", "down" or "frame", > and current GDB does not. > > To fix this regression, I added another (sufficient) condition for To be more precise, s/I added/this patch adds/