Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: "pcarroll@codesourcery.com" <pcarroll@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Modify Aarch64 prologue analyzer to accept 128-bit registers
Date: Mon, 13 Nov 2017 17:32:00 -0000	[thread overview]
Message-ID: <CA+=Sn1kCsyVAKcCFQB4MOP6JRkHCoossWYS8RBEvJQaYWrFxDw@mail.gmail.com> (raw)
In-Reply-To: <1816677702.1219332.1510594086497@mail.yahoo.com>

On Mon, Nov 13, 2017 at 9:28 AM, pcarroll@codesourcery.com
<pcarroll@codesourcery.com> wrote:
> GDB has a routine, aarch64_analyze_prologue, that looks through a function's prologue, to see how it affects the stack.
> This was changed for Bugzilla #20682 to add support for recognizing the 'stp' instruction with floating-point registers.
> That patch worked when 64-bit floating-point registers are used in a function prologue.
> However, it is also possible to specify 128-bit floating-point registers with the 'stp' instruction.
> My patch extends that function so it works for either 64-bit or 128-bit floating-point registers.
> The patch takes care of tracking the appropriate memory locations that would be affected by the use of either size of register.
>
> The assumption is that it is not important to know whether the register being saved is 64-bits or 128-bits in size, as long as the memory is tracked appropriately.
> Instead, it is only important to know that a floating-point register (D) was being stored, rather than a normal register (X).
> That behavior is unchanged.

Hmm,  The normal elf aarch64 ABI says only 64bits is saved.  Is there
another ABI which says 128bits of the SIMD register is saved?

Thanks,
Andrew

>
> 2017-11-10  Paul Carroll  <pcarroll@codesourcery.com>
>
>              * aarch64-tdep.c (aarch64_analyze_prologue):  Added support for
>              128-bit registers with the 'stp' instruction.


  reply	other threads:[~2017-11-13 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1816677702.1219332.1510594086497.ref@mail.yahoo.com>
2017-11-13 17:28 ` pcarroll
2017-11-13 17:32   ` Andrew Pinski [this message]
2017-11-14 14:01     ` Paul Carroll
2017-11-14 14:12       ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1kCsyVAKcCFQB4MOP6JRkHCoossWYS8RBEvJQaYWrFxDw@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pcarroll@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox