Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kaushik Phatak <Kaushik.Phatak@kpitcummins.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [RFA 4/5] New port: CR16: gdbserver
Date: Wed, 26 Jun 2013 08:03:00 -0000	[thread overview]
Message-ID: <C6CA53A2A46BA7469348BDBD663AB65853091CA0@KCHJEXMB02.kpit.com> (raw)
In-Reply-To: <51C9E48B.7050605@redhat.com>

>> I'm not clear on point #2, but the rest sounds excellent.  Thanks!

Thanks for the review and kind words.
I have tried to answer point #2 in my gdb port reply. I may add the "r0r1_orig"
register into the port to support system restarting similar to other ports.

>> Add empty line between describing comment and function definition.
I will run through the code again and fix up the formatting.

Thanks,
Kaushik



      reply	other threads:[~2013-06-26  7:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04 10:23 Kaushik Phatak
2012-12-14 18:47 ` Pedro Alves
2012-12-28  4:42   ` Kaushik Phatak
2013-01-18 16:39     ` Pedro Alves
2013-01-22 13:43       ` Kaushik Phatak
2013-01-22 15:05         ` Pedro Alves
2013-01-23 12:50           ` Kaushik Phatak
2013-01-23 13:29             ` Pedro Alves
2013-01-23 14:04               ` Kaushik Phatak
2013-01-23 14:44                 ` Pedro Alves
2013-06-19 14:10                   ` Kaushik Phatak
2013-06-25 19:10                     ` Pedro Alves
2013-06-26  8:03                       ` Kaushik Phatak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C6CA53A2A46BA7469348BDBD663AB65853091CA0@KCHJEXMB02.kpit.com \
    --to=kaushik.phatak@kpitcummins.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox