From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26912 invoked by alias); 26 Jun 2013 07:08:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26898 invoked by uid 89); 26 Jun 2013 07:08:29 -0000 X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from co9ehsobe005.messaging.microsoft.com (HELO co9outboundpool.messaging.microsoft.com) (207.46.163.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 26 Jun 2013 07:08:29 +0000 Received: from mail220-co9-R.bigfish.com (10.236.132.228) by CO9EHSOBE022.bigfish.com (10.236.130.85) with Microsoft SMTP Server id 14.1.225.23; Wed, 26 Jun 2013 07:08:27 +0000 Received: from mail220-co9 (localhost [127.0.0.1]) by mail220-co9-R.bigfish.com (Postfix) with ESMTP id 70B10260513; Wed, 26 Jun 2013 07:08:27 +0000 (UTC) X-Forefront-Antispam-Report: CIP:59.163.77.177;KIP:(null);UIP:(null);IPV:NLI;H:KCHJEXHC02.kpit.com;RD:59.163.77.177.static.vsnl.net.in;EFVD:NLI X-SpamScore: -5 X-BigFish: VPS-5(zz103dK4015I1447Izz1f42h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ah1fc6hzzz2dh2a8h668h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh15d0h162dh1631h1758h18e1h1946h19b5h1b0ah1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1155h) Received: from mail220-co9 (localhost.localdomain [127.0.0.1]) by mail220-co9 (MessageSwitch) id 137223050551014_18691; Wed, 26 Jun 2013 07:08:25 +0000 (UTC) Received: from CO9EHSMHS029.bigfish.com (unknown [10.236.132.247]) by mail220-co9.bigfish.com (Postfix) with ESMTP id 0AAEC1C0046; Wed, 26 Jun 2013 07:08:25 +0000 (UTC) Received: from KCHJEXHC02.kpit.com (59.163.77.177) by CO9EHSMHS029.bigfish.com (10.236.130.39) with Microsoft SMTP Server (TLS) id 14.1.225.23; Wed, 26 Jun 2013 07:08:24 +0000 Received: from KCHJEXMB02.kpit.com ([169.254.2.54]) by KCHJEXHC02.kpit.com ([172.10.15.74]) with mapi id 14.03.0123.003; Wed, 26 Jun 2013 12:38:07 +0530 From: Kaushik Phatak To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [RFA 4/5] New port: CR16: gdbserver Date: Wed, 26 Jun 2013 08:03:00 -0000 Message-ID: References: <50CB742E.9090506@redhat.com> <50F97ABF.4060203@redhat.com> <50FFE596.20303@redhat.com> <50FFF730.9050108@redhat.com> <51C9E48B.7050605@redhat.com> In-Reply-To: <51C9E48B.7050605@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: kpitcummins.com X-SW-Source: 2013-06/txt/msg00758.txt.bz2 >> I'm not clear on point #2, but the rest sounds excellent. Thanks! Thanks for the review and kind words. I have tried to answer point #2 in my gdb port reply. I may add the "r0r1_o= rig" register into the port to support system restarting similar to other ports. >> Add empty line between describing comment and function definition. I will run through the code again and fix up the formatting. Thanks, Kaushik