Re: [PATCH] Add -nx for "xgdb" test in gdb/testsuite/gdb.gdb/selftest.exp

[Khoo Yit Phang <khooyp@cs.umd.edu>]

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]

Hi,

I found a few more tests with the same issue, here's an updated patch that covers those tests.

Thanks,

Yit
September 2, 2012


[-- Attachment #2: xgdb-no-init.txt --]
[-- Type: text/plain, Size: 2609 bytes --]

Add -nx option to "xgdb" test to prevent spurious results due to ~/.gdbinit.

gdb/testsuite/ChangeLog

2012-09-02  Khoo Yit Phang  <khooyp@cs.umd.edu>

	Add -nx option to "xgdb" tests to avoid spurious results due to
	~/.gdbinit.
	* gdb.gdb/complaint.exp (setup_test): Add -nx option to run
	command.
	* gdb.gdb/observer.exp (setup_test): Ditto.
	* gdb.gdb/selftest.exp (test_with_self): Ditto.
	* gdb.gdb/xfullpath.exp (setup_test): Ditto.

diff --git a/gdb/testsuite/gdb.gdb/complaints.exp b/gdb/testsuite/gdb.gdb/complaints.exp
--- a/gdb/testsuite/gdb.gdb/complaints.exp
+++ b/gdb/testsuite/gdb.gdb/complaints.exp
@@ -73,7 +73,7 @@
     set timeout 600
 
     set description "run until breakpoint at captured_command_loop"
-    gdb_test_multiple "run -nw" "$description" {
+    gdb_test_multiple "run -nw -nx" "$description" {
         -re "Starting program.*Breakpoint \[0-9\]+,.*captured_command_loop .data.* at .*main.c:.*$gdb_prompt $" {
             pass "$description"
         }
diff --git a/gdb/testsuite/gdb.gdb/observer.exp b/gdb/testsuite/gdb.gdb/observer.exp
--- a/gdb/testsuite/gdb.gdb/observer.exp
+++ b/gdb/testsuite/gdb.gdb/observer.exp
@@ -67,7 +67,7 @@
     set timeout 600
 
     set description "run until breakpoint at captured_main"
-    gdb_test_multiple "run -nw" "$description" {
+    gdb_test_multiple "run -nw -nx" "$description" {
         -re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.* at .*main.c:.*$gdb_prompt $" {
             pass "$description"
         }
diff --git a/gdb/testsuite/gdb.gdb/selftest.exp b/gdb/testsuite/gdb.gdb/selftest.exp
--- a/gdb/testsuite/gdb.gdb/selftest.exp
+++ b/gdb/testsuite/gdb.gdb/selftest.exp
@@ -303,7 +303,7 @@
     set timeout 600
 
     set description "run until breakpoint at captured_main"
-    gdb_test_multiple "run -nw" "$description" {
+    gdb_test_multiple "run -nw -nx" "$description" {
 	-re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.* at .*main.c:.*$gdb_prompt $" {
 	    pass "$description"
 	}
diff --git a/gdb/testsuite/gdb.gdb/xfullpath.exp b/gdb/testsuite/gdb.gdb/xfullpath.exp
--- a/gdb/testsuite/gdb.gdb/xfullpath.exp
+++ b/gdb/testsuite/gdb.gdb/xfullpath.exp
@@ -67,7 +67,7 @@
     set timeout 600
 
     set description "run until breakpoint at captured_main"
-    gdb_test_multiple "run -nw" "$description" {
+    gdb_test_multiple "run -nw -nx" "$description" {
         -re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.* at .*main.c:.*$gdb_prompt $" {
             pass "$description"
         }

[-- Attachment #3: Type: text/plain, Size: 330 bytes --]



On Sep 1, 2012, at 11:00 AM, Khoo Yit Phang wrote:

> Hi,
> 
> The "xgdb" test in gdb/testsuite/gdb.gdb/selftest.exp was giving me spurious results since it was loading ~/.gdbinit. Here's a patch that adds the -nx option to prevent this problem.
> 
> Thanks,
> 
> Yit
> September 1, 2012
> 
> <xgdb-no-init.txt>