From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2403 invoked by alias); 3 Sep 2012 02:40:46 -0000 Received: (qmail 2274 invoked by uid 22791); 3 Sep 2012 02:40:44 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,TW_XG X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Sep 2012 02:40:31 +0000 Received: from [192.168.2.10] (pool-72-83-72-24.washdc.east.verizon.net [72.83.72.24]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id 0BE8FB4022C; Sun, 2 Sep 2012 22:40:28 -0400 (EDT) Subject: Re: [PATCH] Add -nx for "xgdb" test in gdb/testsuite/gdb.gdb/selftest.exp Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/mixed; boundary=Apple-Mail-23--1034360078 From: Khoo Yit Phang In-Reply-To: <387EE3E3-80B3-42E0-AFE7-1BAA78B422D3@cs.umd.edu> Date: Mon, 03 Sep 2012 02:40:00 -0000 Cc: GDB Patches Message-Id: References: <387EE3E3-80B3-42E0-AFE7-1BAA78B422D3@cs.umd.edu> To: Khoo Yit Phang X-CSD-MailScanner-ID: 0BE8FB4022C.AF7D5 X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-50, required 5, autolearn=not spam, ALL_TRUSTED -50.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1347244829.41045@smPFVYQ5XDqC5OW0XY7Brg Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00008.txt.bz2 --Apple-Mail-23--1034360078 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Content-length: 135 Hi, I found a few more tests with the same issue, here's an updated patch that = covers those tests. Thanks, Yit September 2, 2012 --Apple-Mail-23--1034360078 Content-Disposition: attachment; filename=xgdb-no-init.txt Content-Type: text/plain; x-unix-mode=0600; name="xgdb-no-init.txt" Content-Transfer-Encoding: quoted-printable Content-length: 2571 Add -nx option to "xgdb" test to prevent spurious results due to ~/.gdbinit. gdb/testsuite/ChangeLog 2012-09-02 Khoo Yit Phang Add -nx option to "xgdb" tests to avoid spurious results due to ~/.gdbinit. * gdb.gdb/complaint.exp (setup_test): Add -nx option to run command. * gdb.gdb/observer.exp (setup_test): Ditto. * gdb.gdb/selftest.exp (test_with_self): Ditto. * gdb.gdb/xfullpath.exp (setup_test): Ditto. diff --git a/gdb/testsuite/gdb.gdb/complaints.exp b/gdb/testsuite/gdb.gdb/c= omplaints.exp --- a/gdb/testsuite/gdb.gdb/complaints.exp +++ b/gdb/testsuite/gdb.gdb/complaints.exp @@ -73,7 +73,7 @@ set timeout 600 =20 set description "run until breakpoint at captured_command_loop" - gdb_test_multiple "run -nw" "$description" { + gdb_test_multiple "run -nw -nx" "$description" { -re "Starting program.*Breakpoint \[0-9\]+,.*captured_command_loop= .data.* at .*main.c:.*$gdb_prompt $" { pass "$description" } diff --git a/gdb/testsuite/gdb.gdb/observer.exp b/gdb/testsuite/gdb.gdb/obs= erver.exp --- a/gdb/testsuite/gdb.gdb/observer.exp +++ b/gdb/testsuite/gdb.gdb/observer.exp @@ -67,7 +67,7 @@ set timeout 600 =20 set description "run until breakpoint at captured_main" - gdb_test_multiple "run -nw" "$description" { + gdb_test_multiple "run -nw -nx" "$description" { -re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.*= at .*main.c:.*$gdb_prompt $" { pass "$description" } diff --git a/gdb/testsuite/gdb.gdb/selftest.exp b/gdb/testsuite/gdb.gdb/sel= ftest.exp --- a/gdb/testsuite/gdb.gdb/selftest.exp +++ b/gdb/testsuite/gdb.gdb/selftest.exp @@ -303,7 +303,7 @@ set timeout 600 =20 set description "run until breakpoint at captured_main" - gdb_test_multiple "run -nw" "$description" { + gdb_test_multiple "run -nw -nx" "$description" { -re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.* at .*m= ain.c:.*$gdb_prompt $" { pass "$description" } diff --git a/gdb/testsuite/gdb.gdb/xfullpath.exp b/gdb/testsuite/gdb.gdb/xf= ullpath.exp --- a/gdb/testsuite/gdb.gdb/xfullpath.exp +++ b/gdb/testsuite/gdb.gdb/xfullpath.exp @@ -67,7 +67,7 @@ set timeout 600 =20 set description "run until breakpoint at captured_main" - gdb_test_multiple "run -nw" "$description" { + gdb_test_multiple "run -nw -nx" "$description" { -re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.*= at .*main.c:.*$gdb_prompt $" { pass "$description" } --Apple-Mail-23--1034360078 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Content-length: 327 On Sep 1, 2012, at 11:00 AM, Khoo Yit Phang wrote: > Hi, >=20 > The "xgdb" test in gdb/testsuite/gdb.gdb/selftest.exp was giving me spuri= ous results since it was loading ~/.gdbinit. Here's a patch that adds the -= nx option to prevent this problem. >=20 > Thanks, >=20 > Yit > September 1, 2012 >=20 > --Apple-Mail-23--1034360078--