RE: [PATCH] gdb: move bfd_open_from_target_memory to gdb_bfd

["Strasuns, Mihails via Gdb-patches" <gdb-patches@sourceware.org>]

Amended and pushed as 15cc148fb8.

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Wednesday, December 9, 2020 10:31 PM
> To: Mihails Strasuns via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Strasuns, Mihails <mihails.strasuns@intel.com>
> Subject: Re: [PATCH] gdb: move bfd_open_from_target_memory to
> gdb_bfd
> 
> >>>>> "Mihails" == Mihails Strasuns via Gdb-patches <gdb-
> patches@sourceware.org> writes:
> 
> Mihails> This function allows to create a BFD handle using an accessible
> Mihails> memory range in a target memory.  It is currently contained in
> Mihails> a JIT module but this functionality may be of wider usefullness
> Mihails> - for example, reading ELF binaries contained within a core dump.
> 
> Mihails> gdb/ChangeLog:
> Mihails> 2020-12-07  Mihails Strasuns  <miihails.strasuns@intel.com>
> 
> Mihails> 	* jit.c (mem_bfd*, bfd_open_from_target_memory):
> Removed.
> Mihails> 	* gdb_bfd.h (gdb_bfd_open_from_target_memory): New
> function.
> Mihails> 	* gdb_bfd.c (mem_bfd*,
> gdb_bfd_open_from_target_memory): New functions.
> 
> Hi.  Thank you for the patch.
> It looks good to me.  I found a couple of minor nits, but the patch is OK with
> these fixed.
> 
> Mihails> +/* Create and initialize a BFD handle from a target in-memory
> Mihails> +range.  */
> Mihails> +
> Mihails> +gdb_bfd_ref_ptr
> Mihails> +gdb_bfd_open_from_target_memory (CORE_ADDR addr,
> ULONGEST size,
> Mihails> +				 const char *target,
> Mihails> +				 const char *filename = nullptr);
> 
> In the style style, the return type isn't separated from the function name in a
> declaration.
> 
> Mihails> +  gdb_bfd_ref_ptr nbfd (gdb_bfd_open_from_target_memory (
> Mihails> +      code_entry->symfile_addr, code_entry->symfile_size,
> Mihails> + gnutarget));
> 
> The formatting here looks weird.  Normally breaks would occur before "(".
> 
> Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928