From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Np3+Nsj10V8zNgAAWB0awg (envelope-from ) for ; Thu, 10 Dec 2020 05:17:44 -0500 Received: by simark.ca (Postfix, from userid 112) id D612F1F0A9; Thu, 10 Dec 2020 05:17:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2B6161E552 for ; Thu, 10 Dec 2020 05:17:41 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6B4983840C28; Thu, 10 Dec 2020 10:17:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B4983840C28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607595460; bh=s3QowDrips84iW0MFTN+xqdz49JK8QYq6zBodBfsZ0o=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=vbQ5krSGV1JULxbZoTbn+kIK/Yf8oOMS2qTh/XonrjKTFHIPs8gK3+FxrMTLoqWE4 oidZNY6ZTQxkSy/jGqbvvPMPCUfVJ8k9vzZ0ESU805nktO8HRGpvXmY1NESUH2C2Cy pZRSleDP4IlmHalmft3GzRoW7awg4mprjE7Gl+mQ= Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id 7941E3871015 for ; Thu, 10 Dec 2020 10:17:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7941E3871015 IronPort-SDR: J2pJ9wRVDro+gQWhy5mP+EUwcNCmbvZFccgLoOGGpNuk5p7S05ny4jPpZjbHaIVosXgQm9ECCN /O4z+lvX/+gA== X-IronPort-AV: E=McAfee;i="6000,8403,9830"; a="161989718" X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="161989718" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 02:17:30 -0800 IronPort-SDR: RR519IcrtE4gwjSQQWs/xyntGluvlyJc7trjqSOfqpi1wkKKmj/qHcjOjExfaiKKpehvQ3UqfB ceG6OroL1ZTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="368812249" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 10 Dec 2020 02:17:30 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 10 Dec 2020 02:17:29 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 10 Dec 2020 02:17:29 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 10 Dec 2020 02:17:29 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 10 Dec 2020 02:17:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GQ5BDPG4QUDfg5uZ0/hO+NDHC+Db0s+rsZ/Rb4QHzIcepSV5lnXg6XMNeNeGjTgmUenuEbf8jNd4SmYARwXl6PBXUuwQc4XkgfM//7xadRMJr2ljpzDAVHU4lS2R3iMdcA0hmmLnrsGm9KBBUgX0sgsrrWKqUpaSufZPFbHBgNkmhtvkUo1T/7JJajsvLZ4hjU0fTk++HvkNMUYRfuceIVSZHhf70qSPdI3D1WoAI63Us2tXEfXxsvuCK/HO/n9V7aWKYXbbK8GBsK1ejhADldfRxQz650KtnxEPbkkXO1ogYLXZWS0kKiGA+4VltbLAH7Jh699L0e/7vDxV/k+0mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b4VYJAFSA4VISG4vt7li+3nOG1aiXJ56jh3/+2ulnUI=; b=DZh1mFF9ljyItgZATIw75AoTtPRjdnJ+M1VtJ8CddaRDiurOWrt8vxoom/VbEFEYnkl6mjojb7DHq7xu5w0Wswca8HP+T7gW2w/si4X7TTBwcykCG3LhtHp0t+zawtKi0lmyUEJ1kT/8jWVbQMy8kmku3UpQOgTgb9lCmaG3O+g4hpYegloqjR46ccTJQAN2vayIw7bWE9q0vnSWWozKDIWdA3F1VDTl/awhD6lwDEfjz15IrxemfcIuBZGC7EF9iQOdulUXADeX51pmL4Tzmu9eqZA1Hf9HBlHNQbTwwuqvobCFKf49+xSkwlcHLQYa2O6b5vknTK1i3gh9/ZWIaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN6PR11MB1858.namprd11.prod.outlook.com (2603:10b6:404:100::22) by BN8PR11MB3571.namprd11.prod.outlook.com (2603:10b6:408:8f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Thu, 10 Dec 2020 10:17:25 +0000 Received: from BN6PR11MB1858.namprd11.prod.outlook.com ([fe80::adfe:b539:4a40:5f82]) by BN6PR11MB1858.namprd11.prod.outlook.com ([fe80::adfe:b539:4a40:5f82%4]) with mapi id 15.20.3632.021; Thu, 10 Dec 2020 10:17:25 +0000 To: Tom Tromey , Mihails Strasuns via Gdb-patches Subject: RE: [PATCH] gdb: move bfd_open_from_target_memory to gdb_bfd Thread-Topic: [PATCH] gdb: move bfd_open_from_target_memory to gdb_bfd Thread-Index: AQHWzUVLBAmMGjifIUGHpijljg8XF6nvSrQLgADV4hA= Date: Thu, 10 Dec 2020 10:17:25 +0000 Message-ID: References: <20201208093447.15381-1-mihails.strasuns@intel.com> <875z5ar7jf.fsf@tromey.com> In-Reply-To: <875z5ar7jf.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [134.191.221.113] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 653284fa-e322-413d-b839-08d89cf4caac x-ms-traffictypediagnostic: BN8PR11MB3571: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FmdePuAGS9gHtQGIDPOd/OV2/N7I8mP8YeToiHCeml2CUMymrnCAEGlGeYYfHalWcdExvAu3ZW8fNgpyMy6Dzg/sYidoEqWGDxqBH2saIOoMrBVzbfaSJIxxmYes2TXGhXEh4vHex8GmoKUw+Gvsz9gXBUYOPPAVgk1IglM3NRHLFcRDMZtW3701/Snckbn7xbORavQDKauyqumCp+L9H76xkq29HtnWrDw8bqGkIBO9fJaCAG59TPq3oFgJtv9XmKNVGz+563an1GUibAiWLbLJlisyS1sAuxUNEVOVA8H3HQNheSGLEUyx8osVIIGHqUk4iiyO8KLfA23+egeclw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1858.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(136003)(376002)(6506007)(186003)(110136005)(64756008)(66446008)(53546011)(66476007)(52536014)(2906002)(66556008)(5660300002)(66946007)(33656002)(71200400001)(76116006)(9686003)(8936002)(86362001)(55016002)(8676002)(83380400001)(26005)(508600001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?bGq6CfLiioYie/Ah+Y6FZ8+T7R5oPblNZUULtc5kfbRfRPF25edP0wzC8LGL?= =?us-ascii?Q?vXK3kn5mvA7bpFlO3/dZITHfgK9d2dkbYAwjOqY+lKrtIgsllCaWz1VoAeg1?= =?us-ascii?Q?6Hc9BeXTDyzy5SAqavsK76VmnJsaIn6NXasgNeSjy5T11eNEFfwUKhw+LWP7?= =?us-ascii?Q?n8gWuj9OxZsdq1seHFlEiuuw4XxFHyDsz8Avq3oXSsO0Hf9HaLfEgVxoDP5i?= =?us-ascii?Q?oE8A4xnkdaHSzCkxxD1/gD0XW+otOu8RzcOfuio8x/Z+UEX5ca8eOSLFzBly?= =?us-ascii?Q?iGJyi2aT1OAtL6tHk1zVGOzorffltAbM3suUHpfq4Frq9aeDgc7mOIl2wjjl?= =?us-ascii?Q?3e/C6ykRuV7Hj5S5yWz8P6NsXqwEGPWDF/47fddOe+Zi8NZ8hlgQHnYbXqMX?= =?us-ascii?Q?/CGLQNeTsVG5Prhc43ZyO3KdAAGGsrKpIM0ihnmCJur0mHI8hsLCJN8oqb1j?= =?us-ascii?Q?neoe2IpDavL97SjXsciwL9Fo5ImKT08EsQRHMlZNOv4Kd0jRn46ncJTVsTXh?= =?us-ascii?Q?qjDDJTcPLXWqtukAEfXM6gFQXVxTlV1Wa/8FhFsnVB4LgZjzcn4p6flurR8p?= =?us-ascii?Q?+XeOVsgoZdTU6z4KadZKlIe8zvEEK8sJX52sVsPqtF2ReGhjzx4t2KcVUIWO?= =?us-ascii?Q?ntJ7HlGnkk/ecTJZ9/HDevNAZ439LGdI729Eg2rccZQBBuvFzQsZX5aAG5Le?= =?us-ascii?Q?WnoCsg0aMdxe5yk4c2lLOZtwmusrKJLwzUBOLtnJnkro+ClX/m7oK1lsTmrb?= =?us-ascii?Q?V57uXAB5Zw0E30pHh+fpPmUD7Imgmen2YFKAcLVEcvAKUYsBwIPssemPhjOT?= =?us-ascii?Q?DHnyvswvI/RMyNP8ukx6pcBzmA0sSqpqAXVdp8bFjL8432v4sG5WZZANh70w?= =?us-ascii?Q?Vluoj/zy7DrgGCn+iizCExMlHjq1gTKJSn6DV2f0dnyLrA/KVwiAe5DgV4aD?= =?us-ascii?Q?L3Pq1V3hD2QveX0tdWrZ3bkcMjUjNZ9MUtkTehgVF0U=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1858.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 653284fa-e322-413d-b839-08d89cf4caac X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2020 10:17:25.8465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u52CW/4rVlcuyX0ZRlsJfslhiMM3pYb/OdVUwFyQH/dVbvrDUZBdsXt5WjLvnzbzox/I3L8iZ0io5WKxU7fg6/Lk4JRLQ5qJgOoP3X8u02w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3571 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Strasuns, Mihails via Gdb-patches" Reply-To: "Strasuns, Mihails" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Amended and pushed as 15cc148fb8. > -----Original Message----- > From: Tom Tromey > Sent: Wednesday, December 9, 2020 10:31 PM > To: Mihails Strasuns via Gdb-patches > Cc: Strasuns, Mihails > Subject: Re: [PATCH] gdb: move bfd_open_from_target_memory to > gdb_bfd > = > >>>>> "Mihails" =3D=3D Mihails Strasuns via Gdb-patches patches@sourceware.org> writes: > = > Mihails> This function allows to create a BFD handle using an accessible > Mihails> memory range in a target memory. It is currently contained in > Mihails> a JIT module but this functionality may be of wider usefullness > Mihails> - for example, reading ELF binaries contained within a core dump. > = > Mihails> gdb/ChangeLog: > Mihails> 2020-12-07 Mihails Strasuns > = > Mihails> * jit.c (mem_bfd*, bfd_open_from_target_memory): > Removed. > Mihails> * gdb_bfd.h (gdb_bfd_open_from_target_memory): New > function. > Mihails> * gdb_bfd.c (mem_bfd*, > gdb_bfd_open_from_target_memory): New functions. > = > Hi. Thank you for the patch. > It looks good to me. I found a couple of minor nits, but the patch is OK= with > these fixed. > = > Mihails> +/* Create and initialize a BFD handle from a target in-memory > Mihails> +range. */ > Mihails> + > Mihails> +gdb_bfd_ref_ptr > Mihails> +gdb_bfd_open_from_target_memory (CORE_ADDR addr, > ULONGEST size, > Mihails> + const char *target, > Mihails> + const char *filename =3D nullptr); > = > In the style style, the return type isn't separated from the function nam= e in a > declaration. > = > Mihails> + gdb_bfd_ref_ptr nbfd (gdb_bfd_open_from_target_memory ( > Mihails> + code_entry->symfile_addr, code_entry->symfile_size, > Mihails> + gnutarget)); > = > The formatting here looks weird. Normally breaks would occur before "(". > = > Tom Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Gary Kershaw Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928