Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Chen Gang <xili_gchen_5257@hotmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: binutils@sourceware.org,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	bug-readline@gnu.org
Subject: Re: [PATCH] readline: rlmbutil.h: Declare wcwidth() when HANDLE_MULTIBYTE enabled.
Date: Sun, 19 Apr 2015 18:46:00 -0000	[thread overview]
Message-ID: <BLU437-SMTP2FD98E5F844FB76180871B9E10@phx.gbl> (raw)
In-Reply-To: <87a8y4ktr7.fsf@igel.home>

On 4/19/15 23:44, Andreas Schwab wrote:
> Chen Gang <xili_gchen_5257@hotmail.com> writes:
> 
>> On fedora 20 x86_64, it has wcwidth() in libc.so.6, but does not declare
>> it if __USE_XOPEN disabled. readline uses libc library, but does not use
>> XOPEN,
> 
> It does, but config.h.in fails to provide the necessary template.
> 
> Andreas.
> 
> 	* readline/config.h.in: Add missing templates.

OK, thanks. It sounds reasonable to me (in this case, it is about
_GNU_SOURCE).

> ---
>  readline/config.h.in | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)
> 
> diff --git a/readline/config.h.in b/readline/config.h.in
> index 8560c4b..f50956e 100644
> --- a/readline/config.h.in
> +++ b/readline/config.h.in
> @@ -6,6 +6,14 @@
>  
>  #undef _FILE_OFFSET_BITS
>  
> +#undef __EXTENSIONS__
> +#undef _ALL_SOURCE
> +#undef _GNU_SOURCE
> +#undef _POSIX_SOURCE
> +#undef _POSIX_1_SOURCE
> +#undef _POSIX_PTHREAD_SEMANTICS
> +#undef _TANDEM_SOURCE
> +
>  /* Define if on MINIX.  */
>  #undef _MINIX
>  
> @@ -27,6 +35,8 @@
>  
>  #undef PROTOTYPES
>  
> +#undef __PROTOTYPES
> +
>  #undef __CHAR_UNSIGNED__
>  
>  /* Define if the `S_IS*' macros in <sys/stat.h> do not work properly.  */
> @@ -71,6 +81,12 @@
>  /* Define if you have the mbrtowc function. */
>  #undef HAVE_MBRTOWC
>  
> +/* Define if you have the mbscmp function. */
> +#undef HAVE_MBSCMP
> +
> +/* Define if you have the mbsnrtowcs function. */
> +#undef HAVE_MBSNRTOWCS
> +
>  /* Define if you have the mbsrtowcs function. */
>  #undef HAVE_MBSRTOWCS
>  
> @@ -118,6 +134,9 @@
>  /* Define if you have the wcscoll function.  */
>  #undef HAVE_WCSCOLL
>  
> +/* Define if you have the wcsdup function.  */
> +#undef HAVE_WCSDUP
> +
>  /* Define if you have the wctype function.  */
>  #undef HAVE_WCTYPE
>  
> @@ -235,9 +254,9 @@
>  
>  #undef HAVE_GETPW_DECLS
>  
> -#undef STRUCT_DIRENT_HAS_D_INO
> +#undef HAVE_STRUCT_DIRENT_D_INO
>  
> -#undef STRUCT_DIRENT_HAS_D_FILENO
> +#undef HAVE_STRUCT_DIRENT_D_FILENO
>  
>  #undef HAVE_BSD_SIGNALS
>  
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed


      reply	other threads:[~2015-04-19 18:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-19 11:42 Chen Gang
2015-04-19 15:44 ` Andreas Schwab
2015-04-19 18:46   ` Chen Gang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLU437-SMTP2FD98E5F844FB76180871B9E10@phx.gbl \
    --to=xili_gchen_5257@hotmail.com \
    --cc=binutils@sourceware.org \
    --cc=bug-readline@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox