From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78886 invoked by alias); 19 Apr 2015 18:46:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78867 invoked by uid 89); 19 Apr 2015 18:46:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.9 required=5.0 tests=AWL,BAYES_50,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: BLU004-OMC3S19.hotmail.com Received: from blu004-omc3s19.hotmail.com (HELO BLU004-OMC3S19.hotmail.com) (65.55.116.94) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Sun, 19 Apr 2015 18:46:52 +0000 Received: from BLU437-SMTP2 ([65.55.116.74]) by BLU004-OMC3S19.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.22751); Sun, 19 Apr 2015 11:46:50 -0700 X-TMN: [k1dl67gfZxs7XEgMooZkgReB3pPAwe2W] Message-ID: Date: Sun, 19 Apr 2015 18:46:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Andreas Schwab CC: binutils@sourceware.org, "gdb-patches@sourceware.org" , bug-readline@gnu.org Subject: Re: [PATCH] readline: rlmbutil.h: Declare wcwidth() when HANDLE_MULTIBYTE enabled. References: <87a8y4ktr7.fsf@igel.home> In-Reply-To: <87a8y4ktr7.fsf@igel.home> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00729.txt.bz2 On 4/19/15 23:44, Andreas Schwab wrote: > Chen Gang writes: > >> On fedora 20 x86_64, it has wcwidth() in libc.so.6, but does not declare >> it if __USE_XOPEN disabled. readline uses libc library, but does not use >> XOPEN, > > It does, but config.h.in fails to provide the necessary template. > > Andreas. > > * readline/config.h.in: Add missing templates. OK, thanks. It sounds reasonable to me (in this case, it is about _GNU_SOURCE). > --- > readline/config.h.in | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/readline/config.h.in b/readline/config.h.in > index 8560c4b..f50956e 100644 > --- a/readline/config.h.in > +++ b/readline/config.h.in > @@ -6,6 +6,14 @@ > > #undef _FILE_OFFSET_BITS > > +#undef __EXTENSIONS__ > +#undef _ALL_SOURCE > +#undef _GNU_SOURCE > +#undef _POSIX_SOURCE > +#undef _POSIX_1_SOURCE > +#undef _POSIX_PTHREAD_SEMANTICS > +#undef _TANDEM_SOURCE > + > /* Define if on MINIX. */ > #undef _MINIX > > @@ -27,6 +35,8 @@ > > #undef PROTOTYPES > > +#undef __PROTOTYPES > + > #undef __CHAR_UNSIGNED__ > > /* Define if the `S_IS*' macros in do not work properly. */ > @@ -71,6 +81,12 @@ > /* Define if you have the mbrtowc function. */ > #undef HAVE_MBRTOWC > > +/* Define if you have the mbscmp function. */ > +#undef HAVE_MBSCMP > + > +/* Define if you have the mbsnrtowcs function. */ > +#undef HAVE_MBSNRTOWCS > + > /* Define if you have the mbsrtowcs function. */ > #undef HAVE_MBSRTOWCS > > @@ -118,6 +134,9 @@ > /* Define if you have the wcscoll function. */ > #undef HAVE_WCSCOLL > > +/* Define if you have the wcsdup function. */ > +#undef HAVE_WCSDUP > + > /* Define if you have the wctype function. */ > #undef HAVE_WCTYPE > > @@ -235,9 +254,9 @@ > > #undef HAVE_GETPW_DECLS > > -#undef STRUCT_DIRENT_HAS_D_INO > +#undef HAVE_STRUCT_DIRENT_D_INO > > -#undef STRUCT_DIRENT_HAS_D_FILENO > +#undef HAVE_STRUCT_DIRENT_D_FILENO > > #undef HAVE_BSD_SIGNALS > > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed