Re: Windows patch status? (broke build)

Re: Windows patch status? (broke build)

[Paul Schlie]

Re: http://sources.redhat.com/ml/gdb-patches/2005-04/msg00249.html

This patch broke the build of HEAD on ppc-apple-darwin7.9 w/-target=avr:

gcc -c -g -O2     -I. -I/Applications/avr/avr-src/gdb
-I/Applications/avr/avr-src/gdb/config
-DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H
-I/Applications/avr/avr-src/gdb/../include/opcode
-I/Applications/avr/avr-src/gdb/../readline/.. -I../bfd
-I/Applications/avr/avr-src/gdb/../bfd
-I/Applications/avr/avr-src/gdb/../include -I../intl
-I/Applications/avr/avr-src/gdb/../intl  -DMI_OUT=1 -DGDBTK -DTUI=1
-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses
-Wpointer-arith -Wformat-nonliteral -Wunused-label -Wunused-function
-Wuninitialized  /Applications/avr/avr-src/gdb/ser-base.c
/Applications/avr/avr-src/gdb/ser-base.c: In function `ser_base_wait_for':
/Applications/avr/avr-src/gdb/ser-base.c:187: error: storage size of `tv'
isn't known
make[1]: *** [ser-base.o] Error 1
make: *** [all-gdb] Error 2

Re: Windows patch status? (broke build)

[Mark Mitchell]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Paul Schlie wrote:
> Re: http://sources.redhat.com/ml/gdb-patches/2005-04/msg00249.html
> 
> This patch broke the build of HEAD on ppc-apple-darwin7.9 w/-target=avr:

Does this fix it?  If so, is this OK to check in, with a ChangeLog?

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 532 bytes --]

Index: ser-base.c
===================================================================
RCS file: /cvs/src/src/gdb/ser-base.c,v
retrieving revision 1.3
diff -c -5 -p -r1.3 ser-base.c
*** ser-base.c	21 Apr 2005 05:34:33 -0000	1.3
--- ser-base.c	22 Apr 2005 05:13:03 -0000
***************
*** 22,31 ****
--- 22,32 ----
  
  #include "defs.h"
  #include "serial.h"
  #include "ser-unix.h"
  #include "event-loop.h"
+ #include <sys/time.h>
  #ifdef USE_WIN32API
  #include <winsock2.h>
  #endif
  
  static timer_handler_func push_event;

Re: Windows patch status? (broke build)

[Eli Zaretskii]

> Date: Thu, 21 Apr 2005 23:15:32 -0400
> From: Paul Schlie <schlie@comcast.net>
> CC: <gdb-patches@sources.redhat.com>
> 
> Re: http://sources.redhat.com/ml/gdb-patches/2005-04/msg00249.html
> 
> This patch broke the build of HEAD on ppc-apple-darwin7.9 w/-target=avr:
> 
> gcc -c -g -O2     -I. -I/Applications/avr/avr-src/gdb
> -I/Applications/avr/avr-src/gdb/config
> -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H
> -I/Applications/avr/avr-src/gdb/../include/opcode
> -I/Applications/avr/avr-src/gdb/../readline/.. -I../bfd
> -I/Applications/avr/avr-src/gdb/../bfd
> -I/Applications/avr/avr-src/gdb/../include -I../intl
> -I/Applications/avr/avr-src/gdb/../intl  -DMI_OUT=1 -DGDBTK -DTUI=1
> -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses
> -Wpointer-arith -Wformat-nonliteral -Wunused-label -Wunused-function
> -Wuninitialized  /Applications/avr/avr-src/gdb/ser-base.c
> /Applications/avr/avr-src/gdb/ser-base.c: In function `ser_base_wait_for':
> /Applications/avr/avr-src/gdb/ser-base.c:187: error: storage size of `tv'
> isn't known
> make[1]: *** [ser-base.o] Error 1
> make: *** [all-gdb] Error 2

I think including <sys/time.h> in ser-base.c will solve this.  Could
you please try?

Re: Windows patch status? (broke build)

[Paul Schlie]

> Mark Mitchell wrote:
>> This patch broke the build of HEAD on ppc-apple-darwin7.9 w/-target=avr:
> 
> Does this fix it?  If so, is this OK to check in, with a ChangeLog?

Yes seems to, it's now built past this point, thank you.

> -- 
> Mark Mitchell
> CodeSourcery, LLC
> mark@codesourcery.com
> (916) 791-8304
> Index: ser-base.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/ser-base.c,v
> retrieving revision 1.3
> diff -c -5 -p -r1.3 ser-base.c
> *** ser-base.c 21 Apr 2005 05:34:33 -0000 1.3
> --- ser-base.c 22 Apr 2005 05:13:03 -0000
> ***************
> *** 22,31 ****
> --- 22,32 ----
>   
>   #include "defs.h"
>   #include "serial.h"
>   #include "ser-unix.h"
>   #include "event-loop.h"
> + #include <sys/time.h>
>   #ifdef USE_WIN32API
>   #include <winsock2.h>
>   #endif
>   
>   static timer_handler_func push_event;

Re: Windows patch status? (broke build)

[Mark Mitchell]

Paul Schlie wrote:
>>Mark Mitchell wrote:
>>
>>>This patch broke the build of HEAD on ppc-apple-darwin7.9 w/-target=avr:
>>
>>Does this fix it?  If so, is this OK to check in, with a ChangeLog?
> 
> 
> Yes seems to, it's now built past this point, thank you.

Good.  I'm just waiting on an OK to check in the fix, then.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

Re: Windows patch status? (broke build)

[Mark Kettenis]

   Date: Fri, 22 Apr 2005 08:53:06 -0700
   From: Mark Mitchell <mark@codesourcery.com>

   Paul Schlie wrote:
   >>Mark Mitchell wrote:
   >>
   >>>This patch broke the build of HEAD on ppc-apple-darwin7.9 w/-target=avr:
   >>
   >>Does this fix it?  If so, is this OK to check in, with a ChangeLog?
   > 
   > 
   > Yes seems to, it's now built past this point, thank you.

   Good.  I'm just waiting on an OK to check in the fix, then.

Go ahead; it's pretty obvious.

Mark

Re: Windows patch status? (broke build)

[Mark Mitchell]

Mark Kettenis wrote:
>    Date: Fri, 22 Apr 2005 08:53:06 -0700
>    From: Mark Mitchell <mark@codesourcery.com>
> 
>    Paul Schlie wrote:
>    >>Mark Mitchell wrote:
>    >>
>    >>>This patch broke the build of HEAD on ppc-apple-darwin7.9 w/-target=avr:
>    >>
>    >>Does this fix it?  If so, is this OK to check in, with a ChangeLog?
>    > 
>    > 
>    > Yes seems to, it's now built past this point, thank you.
> 
>    Good.  I'm just waiting on an OK to check in the fix, then.
> 
> Go ahead; it's pretty obvious.

Committed, thanks.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304