From: Doug Evans <dje@google.com>
To: Stan Shebs <stanshebs@earthlink.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Remove set debug lin-lwp-async, new ui_file.to_write_async_safe
Date: Sat, 14 May 2011 05:45:00 -0000 [thread overview]
Message-ID: <BANLkTinCfCmC64NUG91=g9Q9OEv2JzPv8g@mail.gmail.com> (raw)
In-Reply-To: <4DCD80E3.3030400@earthlink.net>
On Fri, May 13, 2011 at 12:05 PM, Stan Shebs <stanshebs@earthlink.net> wrote:
> On 5/13/11 10:32 AM, Doug Evans wrote:
>>
>> (stdio_file_write_async_safe): New function.
>
> FYI, my build moans about the unchecked result of write() in this, although
> it's not clear what one ought to do with a result.
Yeah. The gcc I was using doesn't warn about this.
Hui Zhu checked in a fix using the same style as the rest of the file
(which was the right thing to do, at least at the moment).
I added a comment because
if (foo ())
;
is so not what I expect to avoid warnings of this kind.
And it looks like the gcc gods decided (void) foo (); wasn't ok. Sigh.
I didn't add comments to the other invocations, but I wouldn't mind them.
next prev parent reply other threads:[~2011-05-14 5:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 20:47 Doug Evans
2011-05-10 20:51 ` Doug Evans
2011-05-10 21:30 ` Pedro Alves
2011-05-10 22:19 ` Doug Evans
2011-05-11 7:39 ` Jan Kratochvil
2011-05-11 15:50 ` Doug Evans
2011-05-13 17:32 ` Doug Evans
2011-05-13 19:05 ` Stan Shebs
2011-05-14 5:45 ` Doug Evans [this message]
2011-05-10 21:38 ` Pedro Alves
2011-05-10 22:20 ` Doug Evans
2011-05-11 2:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinCfCmC64NUG91=g9Q9OEv2JzPv8g@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox