From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20707 invoked by alias); 14 May 2011 05:45:32 -0000 Received: (qmail 20694 invoked by uid 22791); 14 May 2011 05:45:31 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 May 2011 05:45:15 +0000 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id p4E5jDnw011708 for ; Fri, 13 May 2011 22:45:14 -0700 Received: from ywg4 (ywg4.prod.google.com [10.192.7.4]) by wpaz37.hot.corp.google.com with ESMTP id p4E5j9VG006249 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 13 May 2011 22:45:12 -0700 Received: by ywg4 with SMTP id 4so1098689ywg.10 for ; Fri, 13 May 2011 22:45:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.91.33.1 with SMTP id l1mr2043929agj.207.1305351908144; Fri, 13 May 2011 22:45:08 -0700 (PDT) Received: by 10.90.72.6 with HTTP; Fri, 13 May 2011 22:45:07 -0700 (PDT) In-Reply-To: <4DCD80E3.3030400@earthlink.net> References: <20110510204641.A4C73246199@ruffy.mtv.corp.google.com> <201105102230.29758.pedro@codesourcery.com> <20110511073900.GA1776@host1.jankratochvil.net> <4DCD80E3.3030400@earthlink.net> Date: Sat, 14 May 2011 05:45:00 -0000 Message-ID: Subject: Re: [RFA] Remove set debug lin-lwp-async, new ui_file.to_write_async_safe From: Doug Evans To: Stan Shebs Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00335.txt.bz2 On Fri, May 13, 2011 at 12:05 PM, Stan Shebs wrot= e: > On 5/13/11 10:32 AM, Doug Evans wrote: >> >> =A0 =A0 =A0 =A0 (stdio_file_write_async_safe): New function. > > FYI, my build moans about the unchecked result of write() in this, althou= gh > it's not clear what one ought to do with a result. Yeah. The gcc I was using doesn't warn about this. Hui Zhu checked in a fix using the same style as the rest of the file (which was the right thing to do, at least at the moment). I added a comment because if (foo ()) ; is so not what I expect to avoid warnings of this kind. And it looks like the gcc gods decided (void) foo (); wasn't ok. Sigh. I didn't add comments to the other invocations, but I wouldn't mind them.