From: Mike Frysinger <vapier@gentoo.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: toolchain-devel@blackfin.uclinux.org,
Jie Zhang <jie.zhang@analog.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v3] gdb: tests: set remotetimeout to gdb_load_timeout for remote targets
Date: Fri, 01 Jul 2011 00:19:00 -0000 [thread overview]
Message-ID: <BANLkTimm4+oRKSzCYx9G4LMZxU7=XuL5gg@mail.gmail.com> (raw)
In-Reply-To: <20110630225430.GF2407@adacore.com>
On Thu, Jun 30, 2011 at 18:54, Joel Brobecker wrote:
>> v3
>> - add comments to new helper funcs
>> - use gdb_test_multiple
>>
>> gdb/testsuite/config/monitor.exp | 16 +++++++++++++++-
>> gdb/testsuite/lib/gdb.exp | 27 +++++++++++++++++++++++++++
>> 2 files changed, 42 insertions(+), 1 deletions(-)
>
> This version is OK. You forgot to provide a ChangeLog and I forgot
> to remind you about that....
committed with:
2011-06-30 Jie Zhang <jie.zhang@analog.com>
Mike Frysinger <vapier@gentoo.org>
* config/monitor.exp (get_remotetimeout, set_remotetimeout): New
helper functions for getting/setting remotetimeout variable.
* lib/gdb.exp (gdb_load): If the target is remote, set
$oldremotetimeout to get_remotetimeout, then call set_remotetimeout
with $loadtimeout. Set $load_ok to 0 before doing the load.
Instead of returning, immediately, set $load_ok to 0. Call
set_remotetimeout with $oldremotetimeout, and then return if
$load_ok is 1.
-mike
prev parent reply other threads:[~2011-07-01 0:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 21:34 [PATCH] gdb: tests/monitor: " Mike Frysinger
2011-06-18 22:31 ` Mike Frysinger
2011-06-19 19:04 ` [PATCH v2] gdb: tests: " Mike Frysinger
2011-06-29 16:25 ` Joel Brobecker
2011-06-29 17:29 ` Jie Zhang
2011-06-30 8:59 ` Pedro Alves
2011-06-30 13:30 ` [toolchain-devel] " Mike Frysinger
2011-06-30 13:48 ` Pedro Alves
2011-06-29 23:25 ` [PATCH v3] " Mike Frysinger
2011-06-30 22:54 ` Joel Brobecker
2011-07-01 0:19 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimm4+oRKSzCYx9G4LMZxU7=XuL5gg@mail.gmail.com' \
--to=vapier@gentoo.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jie.zhang@analog.com \
--cc=toolchain-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox