From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14760 invoked by alias); 1 Jul 2011 00:19:37 -0000 Received: (qmail 14751 invoked by uid 22791); 1 Jul 2011 00:19:36 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-yw0-f41.google.com (HELO mail-yw0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jul 2011 00:19:22 +0000 Received: by ywb26 with SMTP id 26so1399000ywb.0 for ; Thu, 30 Jun 2011 17:19:21 -0700 (PDT) Received: by 10.91.80.20 with SMTP id h20mr2455786agl.149.1309479561220; Thu, 30 Jun 2011 17:19:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.90.92.18 with HTTP; Thu, 30 Jun 2011 17:19:01 -0700 (PDT) In-Reply-To: <20110630225430.GF2407@adacore.com> References: <1308510312-5512-1-git-send-email-vapier@gentoo.org> <1309389910-30787-1-git-send-email-vapier@gentoo.org> <20110630225430.GF2407@adacore.com> From: Mike Frysinger Date: Fri, 01 Jul 2011 00:19:00 -0000 Message-ID: Subject: Re: [PATCH v3] gdb: tests: set remotetimeout to gdb_load_timeout for remote targets To: Joel Brobecker Cc: toolchain-devel@blackfin.uclinux.org, Jie Zhang , gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00000.txt.bz2 On Thu, Jun 30, 2011 at 18:54, Joel Brobecker wrote: >> v3 >> =C2=A0 =C2=A0 =C2=A0 - add comments to new helper funcs >> =C2=A0 =C2=A0 =C2=A0 - use gdb_test_multiple >> >> =C2=A0gdb/testsuite/config/monitor.exp | =C2=A0 16 +++++++++++++++- >> =C2=A0gdb/testsuite/lib/gdb.exp =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 27 += ++++++++++++++++++++++++++ >> =C2=A02 files changed, 42 insertions(+), 1 deletions(-) > > This version is OK. =C2=A0You forgot to provide a ChangeLog and I forgot > to remind you about that.... committed with: 2011-06-30 Jie Zhang Mike Frysinger * config/monitor.exp (get_remotetimeout, set_remotetimeout): New helper functions for getting/setting remotetimeout variable. * lib/gdb.exp (gdb_load): If the target is remote, set $oldremotetimeout to get_remotetimeout, then call set_remotetimeout with $loadtimeout. Set $load_ok to 0 before doing the load. Instead of returning, immediately, set $load_ok to 0. Call set_remotetimeout with $oldremotetimeout, and then return if $load_ok is 1. -mike