Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ruben Van Boxem <vanboxem.ruben@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org,
		mingw64 <mingw-w64-public@lists.sourceforge.net>
Subject: Re: [PATCH] 64-bit python support
Date: Tue, 10 May 2011 14:32:00 -0000	[thread overview]
Message-ID: <BANLkTikrs+AFqqiQEwQfmD=c3wicjSdWYA@mail.gmail.com> (raw)
In-Reply-To: <m38vuesk7k.fsf@fleche.redhat.com>

2011/5/10 Tom Tromey <tromey@redhat.com>:
>>>>>> "Ruben" == Ruben Van Boxem <vanboxem.ruben@gmail.com> writes:
>
> Ruben> Attached is a patch that tells gdb-python to use the Py_InitModule4_64
> Ruben> function instead of Py_InitModule for 64-bit builds.
>
> I think this should not be needed.  I think the bug must lie somewhere
> else.  I say this because Python's modsupport.h should already do this
> renaming:
>
> #if SIZEOF_SIZE_T != SIZEOF_INT
> /* On a 64-bit system, rename the Py_InitModule4 so that 2.4
>   modules cannot get loaded into a 2.5 interpreter */
> #define Py_InitModule4 Py_InitModule4_64
> #endif

Ah, I didn't know this, that's indeed very handy, but the two
occurrences in my patch are actually still a call to Py_InitModule
without the "4". Then that probably needs to be patched instead?

Ruben

>
> Tom
>


  reply	other threads:[~2011-05-10 14:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BANLkTi=2gphWs2p_5V+wTJMUAkjHDT79uQ__10646.2358417504$1305032253$gmane$org@mail.gmail.com>
2011-05-10 14:29 ` Tom Tromey
2011-05-10 14:32   ` Ruben Van Boxem [this message]
     [not found]   ` <BANLkTikrs+AFqqiQEwQfmD=c3wicjSdWYA__43532.2708603509$1305037944$gmane$org@mail.gmail.com>
2011-05-10 14:38     ` Tom Tromey
2011-05-10 15:03       ` Ruben Van Boxem
2011-05-10 12:57 Ruben Van Boxem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTikrs+AFqqiQEwQfmD=c3wicjSdWYA@mail.gmail.com' \
    --to=vanboxem.ruben@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mingw-w64-public@lists.sourceforge.net \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox